libvirt swap_volume and live_snapshot methods have no unit tests

Bug #1346327 reported by Daniel Berrange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Daniel Berrange

Bug Description

Neither the swap_volume or live_snapshot methods in the libvirt driver have any corresponding coverage in the test_driver.py unit test suite.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/108379

Changed in nova:
assignee: nobody → Daniel Berrange (berrange)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/108379
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f0883800660ab546f5667b973f339c4df4c5c458
Submitter: Jenkins
Branch: master

commit f0883800660ab546f5667b973f339c4df4c5c458
Author: Daniel P. Berrange <email address hidden>
Date: Mon Jul 21 15:09:08 2014 +0100

    libvirt: add tests for _live_snapshot and _swap_volume methods

    The _live_snapshot and _swap_volume methods do a non-trivial
    sequence of libvirt API calls which should be validated in the
    unit tests

    Closes-bug: #1346327
    Change-Id: I14bfa08f0dbb4eaa7c4f069f70c257ba7605989b

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.