Upgrade fails on health check stage "TypeError: 'NoneType' object is unsubscriptable"

[Evgeniy L]

"nailgun_sha": "ae70614f5c839db9d16e417a893310cd5a7ea6b5",

1. install 5.0 master node
2. run upgarde to 5.1

2014-07-21 11:23:23 ERROR 20457 (cli) 'NoneType' object is unsubscriptable
Traceback (most recent call last):
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/cli.py", line 142, in main
    run_upgrade(parse_args())
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/cli.py", line 135, in run_upgrade
    upgrade_manager.run()
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/upgrade.py", line 51, in run
    upgrader.upgrade()
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/engines/docker_engine.py", line 89, in upgrade
    self.upgrade_verifier.verify()
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/health_checker.py", line 374, in verify
    interval=self.config.checker['interval'])
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/utils.py", line 180, in wait_for_true
    result = check()
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/health_checker.py", line 386, in check_if_all_services_ready
    not_running_services = self._get_non_running_services()
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/health_checker.py", line 401, in _get_non_running_services
    set(self._get_running_services()))
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/health_checker.py", line 411, in _get_running_services
    if checker.check():
  File "/var/fuel_upgarde/upgrade/site-packages/fuel_upgrade/health_checker.py", line 226, in check
    if resp and resp['code'] != 200 or not isinstance(resp['body'], list):
TypeError: 'NoneType' object is unsubscriptable
Upgrade failed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/108354

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/108354
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=7da3d31981da16c22f688c4aa65604eebf25dcab
Submitter: Jenkins
Branch: master

commit 7da3d31981da16c22f688c4aa65604eebf25dcab
Author: Evgeniy L <email address hidden>
Date: Mon Jul 21 16:04:15 2014 +0400

    Upgrade, fix mcollective health checker

    Error occurred when rabbitmq was not
    running as result safe_get returned
    None.

    Change-Id: Ibcf2fe4da9431b0f93462d10e7dce18d1b232ef8
    Closes-bug: #1346219

[Andrey Sledzinskiy (asledzinskiy)]

verified on fuel-5.1-upgrade-6-2014-09-13_14-34-19.tar.lrz