FILE vs int API mismatch in JarFile class
Bug #1345930 reported by
Pino Toscano
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
Fix Released
|
Medium
|
Unassigned |
Bug Description
In the open() and close() methods of the JarFile (src/io/inkjar.*) class, there's a an API mismatch usage. That is, there's fopen being used as it is was open, and fd checked as if it was a file descriptor and not a FILE*.
While this might still compile (albeit with compiler warnings, at least with GCC), it won't work at all at runtime.
Attached it is a fix for this issue, produced on top of inkscape 0.48.5.
Related branches
Changed in inkscape: | |
status: | Incomplete → New |
Changed in inkscape: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
> Attached it is a fix for this issue, produced on top
> of inkscape 0.48.5.
There are currently no more bug-fix releases planned for the stable release branch <lp:inkscape/0.48.x>: sourceforge. net/p/inkscape/ mailman/ message/ 32624259/>
<http://
AFAICT similar changes have been committed to trunk already: bazaar. launchpad. net/~inkscape. dev/inkscape/ trunk/annotate/ head:/src/ io/inkjar. cpp#L104>
<http://
Can this report be closed as 'Fix committed' with milestone 0.91, or does the code in trunk need additional fixes too?