widelands

Simplify setbobdescription worker program

Bug #1345741 reported by wl-zocker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned
widelands build19-rc1

Bug Description

This becomes important when https://code.launchpad.net/~wl-zocker/widelands/bug-1341662 will have been merged.
The code around setbobdescription (in src/logic/worker.(cc|h) and src/logic/worker_programm.(cc|h)) can be simplified. There is no need to support tribe bobs anymore.

Related branches

lp:~widelands-dev/widelands/simplify_setbobdescription
GunChleoc: Approve
Diff: 44 lines (+4/-21)
1 file modified
src/logic/map_objects/tribes/worker.cc (+4/-21)
Revision history for this message
SirVer (sirver) wrote :

I am not sure if I analyzed that correctly btw. A quick grep is needed to verify, maybe it is also used for other programs and still uses tribe: then.

Changed in widelands:
status: New → Confirmed
tags: added: lowhangingfruit
Changed in widelands:
milestone: none → build19-rc1
importance: Undecided → Low
summary: - Simplify setbobdescription
+ Simplify setbobdescription worker program
Revision history for this message
GunChleoc (gunchleoc) wrote :

Same as https://bugs.launchpad.net/widelands/+bug/1345733

Leave as is, because the gamekeeper still uses this to "plant" the animals.

Changed in widelands:
status: Confirmed → Invalid
Revision history for this message
SirVer (sirver) wrote :

Why do you think that? I cannot see this in the code. m_bobs is only add()ed to once and it is when the ship is parsed. The gamekeeper uses this only with world bobs now. Setting this back to confirmed - feel free to convince me otherwise :)

Changed in widelands:
status: Invalid → Confirmed
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.