Granite mines should check if their output is needed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
Currently, there are two different designs on how mines work:
1) When there is enough input (stock > target quantity), always produce a ware. When there is not enough input, produce the ware only when it is needed (stock < target quantity). I.e. the mine consumes food even when its output currently is not needed.
This system is currently used for all Atlantean mines, and the Imperial (deep) gold, iron ore, and coal mine.
2) The other mines (all Barbarian mines and the Imperial marble mine, including all enhancements) do always work, even when the economy has no food (there is no check at all).
I suggest the following:
- All mines built on granite plots (granite, marble, crystal) should check whether their output is needed and only produce if that is the case. The idea is that their output is not needed regularily (but only when new buildings are built), so it makes no sense to have hundreds of stones on stock.
- The other mines should work as described in 1. It is then possible to produce ores and coal on stock. This is useful because they are always needed.
If the mines do not produce when their output is not needed and the food producing buildings are changed to do the same (there are some inconsistecies), you end up with having lots of basic food ingredients (water, wheat, raw fish/meat), which are not very useful. When more smelting works are built, this food first has to be processed.
What do others think about this?
Related branches
- SirVer: Approve
-
Diff: 4361 lines (+602/-552)211 files modifiedtribes/atlanteans/advanced_shield/conf (+1/-0)
tribes/atlanteans/blackroot/conf (+1/-2)
tribes/atlanteans/blackroot_farm/conf (+4/-4)
tribes/atlanteans/blackrootflour/conf (+1/-1)
tribes/atlanteans/bread/conf (+1/-1)
tribes/atlanteans/bread_paddle/conf (+2/-0)
tribes/atlanteans/bucket/conf (+2/-0)
tribes/atlanteans/burners_house/conf (+1/-1)
tribes/atlanteans/castle/conf (+5/-6)
tribes/atlanteans/coal/conf (+1/-1)
tribes/atlanteans/coalmine/conf (+5/-6)
tribes/atlanteans/corn/conf (+1/-3)
tribes/atlanteans/cornflour/conf (+1/-0)
tribes/atlanteans/crystalmine/conf (+7/-10)
tribes/atlanteans/diamond/conf (+1/-1)
tribes/atlanteans/double_trident/conf (+1/-1)
tribes/atlanteans/farm/conf (+5/-5)
tribes/atlanteans/fire_tongs/conf (+2/-0)
tribes/atlanteans/fish/conf (+2/-1)
tribes/atlanteans/fish_breeders_house/conf (+5/-5)
tribes/atlanteans/fishers_house/conf (+4/-4)
tribes/atlanteans/fishing_net/conf (+2/-0)
tribes/atlanteans/foresters_house/conf (+4/-4)
tribes/atlanteans/gold/conf (+1/-2)
tribes/atlanteans/golden_tabard/conf (+1/-1)
tribes/atlanteans/goldmine/conf (+6/-7)
tribes/atlanteans/goldore/conf (+1/-0)
tribes/atlanteans/goldyarn/conf (+1/-1)
tribes/atlanteans/guardhall/conf (+3/-3)
tribes/atlanteans/guardhouse/conf (+4/-4)
tribes/atlanteans/hammer/conf (+2/-0)
tribes/atlanteans/heavy_double_trident/conf (+1/-0)
tribes/atlanteans/hook_pole/conf (+2/-0)
tribes/atlanteans/hunters_house/conf (+4/-4)
tribes/atlanteans/hunting_bow/conf (+2/-0)
tribes/atlanteans/iron/conf (+1/-1)
tribes/atlanteans/ironmine/conf (+6/-7)
tribes/atlanteans/ironore/conf (+1/-1)
tribes/atlanteans/light_trident/conf (+1/-3)
tribes/atlanteans/log/conf (+1/-2)
tribes/atlanteans/long_trident/conf (+1/-0)
tribes/atlanteans/meat/conf (+1/-0)
tribes/atlanteans/milking_tongs/conf (+2/-0)
tribes/atlanteans/mill/conf (+5/-4)
tribes/atlanteans/pick/conf (+1/-0)
tribes/atlanteans/planks/conf (+0/-2)
tribes/atlanteans/port/conf (+4/-4)
tribes/atlanteans/quarry/conf (+4/-4)
tribes/atlanteans/quartz/conf (+1/-0)
tribes/atlanteans/scouts_house/conf (+3/-3)
tribes/atlanteans/scythe/conf (+2/-0)
tribes/atlanteans/shovel/conf (+1/-0)
tribes/atlanteans/small_tower/conf (+3/-3)
tribes/atlanteans/smelting_works/conf (+3/-3)
tribes/atlanteans/smoked_fish/conf (+1/-1)
tribes/atlanteans/smoked_meat/conf (+1/-2)
tribes/atlanteans/smokery/conf (+8/-8)
tribes/atlanteans/spidercloth/conf (+1/-1)
tribes/atlanteans/spiderfarm/conf (+1/-2)
tribes/atlanteans/steel_shield/conf (+2/-0)
tribes/atlanteans/steel_trident/conf (+1/-2)
tribes/atlanteans/stone/conf (+1/-1)
tribes/atlanteans/tabard/conf (+1/-1)
tribes/atlanteans/toolsmithy/conf (+4/-4)
tribes/atlanteans/tower/conf (+4/-4)
tribes/atlanteans/water/conf (+1/-1)
tribes/atlanteans/weaving-mill/conf (+3/-3)
tribes/atlanteans/well/conf (+3/-4)
tribes/atlanteans/woodcutters_house/conf (+4/-4)
tribes/barbarians/ax/conf (+2/-1)
tribes/barbarians/axfactory/conf (+4/-4)
tribes/barbarians/bakery/conf (+1/-2)
tribes/barbarians/battlearena/conf (+5/-5)
tribes/barbarians/battleax/conf (+1/-0)
tribes/barbarians/beer/conf (+2/-1)
tribes/barbarians/blackwood/conf (+0/-1)
tribes/barbarians/bread_paddle/conf (+2/-0)
tribes/barbarians/brewery/conf (+2/-2)
tribes/barbarians/broadax/conf (+1/-1)
tribes/barbarians/bronzeax/conf (+2/-0)
tribes/barbarians/burners_house/conf (+1/-1)
tribes/barbarians/citadel/conf (+5/-6)
tribes/barbarians/coal/conf (+0/-1)
tribes/barbarians/coalmine/conf (+5/-4)
tribes/barbarians/deep_coalmine/conf (+5/-4)
tribes/barbarians/deep_goldmine/conf (+5/-4)
tribes/barbarians/deep_oremine/conf (+9/-8)
tribes/barbarians/deeper_coalmine/conf (+4/-3)
tribes/barbarians/deeper_goldmine/conf (+4/-3)
tribes/barbarians/deeper_oremine/conf (+4/-3)
tribes/barbarians/donjon/conf (+8/-9)
tribes/barbarians/fire_tongs/conf (+2/-0)
tribes/barbarians/fish/conf (+1/-0)
tribes/barbarians/fisher/conf (+7/-2)
tribes/barbarians/fishers_hut/conf (+4/-4)
tribes/barbarians/fishing_rod/conf (+2/-0)
tribes/barbarians/fortress/conf (+10/-10)
tribes/barbarians/gamekeepers_hut/conf (+4/-4)
tribes/barbarians/gold/conf (+1/-1)
tribes/barbarians/goldmine/conf (+6/-5)
tribes/barbarians/goldore/conf (+2/-0)
tribes/barbarians/granitemine/conf (+4/-3)
tribes/barbarians/hammer/conf (+2/-0)
tribes/barbarians/helm/conf (+2/-0)
tribes/barbarians/hunters_hut/conf (+3/-3)
tribes/barbarians/hunting_spear/conf (+2/-0)
tribes/barbarians/iron/conf (+2/-1)
tribes/barbarians/ironore/conf (+2/-0)
tribes/barbarians/kitchen_tools/conf (+2/-0)
tribes/barbarians/log/conf (+1/-2)
tribes/barbarians/lumberjacks_hut/conf (+4/-4)
tribes/barbarians/mask/conf (+1/-0)
tribes/barbarians/meal/conf (+1/-1)
tribes/barbarians/meat/conf (+1/-0)
tribes/barbarians/metalworks/conf (+30/-30)
tribes/barbarians/oremine/conf (+6/-5)
tribes/barbarians/pittabread/conf (+1/-1)
tribes/barbarians/port/conf (+4/-4)
tribes/barbarians/quarry/conf (+4/-4)
tribes/barbarians/rangers_hut/conf (+4/-4)
tribes/barbarians/ration/conf (+1/-1)
tribes/barbarians/raw_stone/conf (+2/-1)
tribes/barbarians/scouts_hut/conf (+3/-3)
tribes/barbarians/scythe/conf (+2/-0)
tribes/barbarians/sentry/conf (+5/-5)
tribes/barbarians/sharpax/conf (+1/-2)
tribes/barbarians/shipyard/conf (+4/-4)
tribes/barbarians/shovel/conf (+2/-0)
tribes/barbarians/snack/conf (+1/-4)
tribes/barbarians/strongbeer/conf (+1/-3)
tribes/barbarians/tavern/conf (+5/-11)
tribes/barbarians/thatchreed/conf (+1/-3)
tribes/barbarians/trainingcamp/conf (+5/-5)
tribes/barbarians/warhelm/conf (+2/-0)
tribes/barbarians/warmill/conf (+4/-4)
tribes/barbarians/warriorsax/conf (+1/-0)
tribes/barbarians/water/conf (+1/-2)
tribes/barbarians/well/conf (+4/-4)
tribes/barbarians/wheat/conf (+1/-1)
tribes/empire/advanced_lance/conf (+1/-1)
tribes/empire/armor/conf (+2/-0)
tribes/empire/ax/conf (+1/-0)
tribes/empire/bakery/conf (+4/-4)
tribes/empire/barracks/conf (+0/-1)
tribes/empire/barrier/conf (+2/-3)
tribes/empire/basket/conf (+2/-0)
tribes/empire/bread/conf (+0/-1)
tribes/empire/bread_paddle/conf (+2/-0)
tribes/empire/brewery/conf (+1/-2)
tribes/empire/burners_house/conf (+1/-1)
tribes/empire/castle/conf (+0/-1)
tribes/empire/chain_armor/conf (+1/-0)
tribes/empire/cloth/conf (+1/-2)
tribes/empire/coal/conf (+1/-1)
tribes/empire/coalmine/conf (+5/-6)
tribes/empire/deep_coalmine/conf (+4/-5)
tribes/empire/deep_goldmine/conf (+4/-5)
tribes/empire/deep_marblemine/conf (+4/-3)
tribes/empire/deep_oremine/conf (+4/-5)
tribes/empire/fire_tongs/conf (+2/-0)
tribes/empire/fish/conf (+1/-0)
tribes/empire/fishers_house/conf (+4/-4)
tribes/empire/fishing_rod/conf (+2/-0)
tribes/empire/foresters_house/conf (+4/-4)
tribes/empire/fortress/conf (+4/-5)
tribes/empire/gold/conf (+1/-1)
tribes/empire/goldmine/conf (+6/-7)
tribes/empire/goldore/conf (+1/-0)
tribes/empire/grape/conf (+1/-0)
tribes/empire/hammer/conf (+1/-0)
tribes/empire/heavy_lance/conf (+2/-0)
tribes/empire/helm/conf (+1/-3)
tribes/empire/hunters_house/conf (+3/-3)
tribes/empire/hunting_spear/conf (+2/-0)
tribes/empire/ironore/conf (+1/-0)
tribes/empire/kitchen_tools/conf (+2/-0)
tribes/empire/lance/conf (+1/-0)
tribes/empire/log/conf (+1/-2)
tribes/empire/lumberjacks_house/conf (+4/-4)
tribes/empire/marble/conf (+1/-0)
tribes/empire/marblecolumn/conf (+1/-1)
tribes/empire/marblemine/conf (+7/-5)
tribes/empire/meat/conf (+1/-2)
tribes/empire/mill/conf (+6/-6)
tribes/empire/oremine/conf (+6/-7)
tribes/empire/outpost/conf (+2/-3)
tribes/empire/pick/conf (+1/-0)
tribes/empire/piggery/conf (+4/-5)
tribes/empire/plate_armor/conf (+1/-1)
tribes/empire/port/conf (+4/-4)
tribes/empire/quarry/conf (+4/-4)
tribes/empire/ration/conf (+0/-1)
tribes/empire/saw/conf (+2/-0)
tribes/empire/scouts_house/conf (+3/-3)
tribes/empire/scythe/conf (+2/-0)
tribes/empire/sentry/conf (+4/-5)
tribes/empire/shovel/conf (+2/-0)
tribes/empire/smelting_works/conf (+4/-4)
tribes/empire/stone/conf (+1/-1)
tribes/empire/tavern/conf (+4/-4)
tribes/empire/toolsmithy/conf (+44/-44)
tribes/empire/tower/conf (+2/-3)
tribes/empire/war_lance/conf (+1/-0)
tribes/empire/water/conf (+1/-1)
tribes/empire/weaving-mill/conf (+4/-4)
tribes/empire/well/conf (+4/-4)
tribes/empire/wheat/conf (+1/-2)
tribes/empire/wine/conf (+1/-1)
tribes/empire/wood/conf (+0/-3)
tribes/empire/wood_lance/conf (+1/-2)
tribes/empire/wool/conf (+2/-1)
Changed in widelands: | |
assignee: | wl-zocker (wl-zocker) → nobody |
tags: |
added: gameplay removed: conffiles |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
There are target quantities for each of the outputs (coal, iron, whatever the granite mines produce). All should adhere to that I think. If the user wants to stockpile coal, she can increase the target quantities.