Ophaned Volume Not Removed on Instance Delete

[Mat Lowery]

When the trove.taskmanager.models.FreshInstanceTasks#_create_server_volume_individually path is used, cinderclient is used to create the volume and then that volume is supplied in the block_device_mapping (BDM) in the novaclient call. delete_on_terminate is set to True in that BDM. However, in a scenario in which cinderclient succeeds and the subsequent novaclient fails (e.g. quota), the volume is not cleaned up since there is no nova server.

relevant code-path: https://github.com/openstack/trove/blob/1654031cc6b0fa28efb322717efabf2bebffabf8/trove/taskmanager/models.py#L583-L597

this is not good, because the quotas are rolled back, meaning there's a provisioned volume that's not accounted for.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/125550

[OpenStack Infra (hudson-openstack)]

Change abandoned by Craig Vyvial (<email address hidden>) on branch: master
Review: https://review.openstack.org/125550
Reason: Abandoning due to lack activity updating this patch. Feel free to open this patch back up. Thanks.

[Matt Fischer (mfisch)]

I would argue that this should be high. When this happens you can run out of quota which is not apparent in the trove logs and is confusing to customers.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/334722

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/334722
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=c3d670c2186e681d89cfa511984eff7255ef0826
Submitter: Jenkins
Branch: master

commit c3d670c2186e681d89cfa511984eff7255ef0826
Author: Ali Adil <email address hidden>
Date: Mon Jun 27 20:47:23 2016 -0400

    Ophaned Volume Not Removed on Instance Delete

    When an instance is created with quota issues, the cinder volume is
    created butthe nova instance fails to be created. Deleting the
    instance would fail todelete the volume. Check the status of the
    volume when deleting the instance, if the status of the volume is
    "available" delete the volume as it is not connected to any instance.

    Change-Id: Ie921a8ff2851e2d9d76a3c3836945c750f090c4e
    Closes-Bug: #1344113

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.