tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern failing: "Caught error: 'image_id'"

[Adam Gandelman]

Not certain where the bug is yet, but filing here to have a recheck target.

Noticed two separate patches fail gating in different jobs but on the same test (tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern):

http://logs.openstack.org/30/104730/1/gate/gate-tempest-dsvm-neutron/975e16b/
http://logs.openstack.org/28/102628/4/check/check-grenade-dsvm-partial-ncpu/d2e1673/

Common error in n-api seems to be:

2014-07-17 23:33:31.537 ERROR nova.api.openstack [req-cd950aba-e19c-4c6b-918b-bdfd41d2afce TestVolumeBootPattern-908565911 TestVolumeBootPattern-1581069975] Caught error: 'image_id'

which just started popping up today:

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiQ2F1Z2h0IGVycm9yOiAnaW1hZ2VfaWQnXCIgQU5EIHRhZ3M6XCJzY3JlZW4tbi1hcGkudHh0XCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6IjYwNDgwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6eyJ1c2VyX2ludGVydmFsIjowfSwic3RhbXAiOjE0MDU2NDE3OTMwMzl9

[Matt Riedemann (mriedem)]

This is the change that introduced the regression:

https://github.com/openstack/nova/commit/c3191cf0ba5ad3dc2df8da2a2bf5c9d270fde9d9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/107875

[Nikola Đipanov (ndipanov)]

The commit that intruduces it is wrong for several reasons which I outline on the original bug: https://bugs.launchpad.net/nova/+bug/1317880. That should have never been merged!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/107875
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=97f81734c030f7f704369b37e1fe122c7040b9a6
Submitter: Jenkins
Branch: master

commit 97f81734c030f7f704369b37e1fe122c7040b9a6
Author: Matt Riedemann <email address hidden>
Date: Sat Jul 19 10:04:12 2014 -0700

    Revert "Add missing image to instance booted from volume"

    This reverts commit c3191cf0ba5ad3dc2df8da2a2bf5c9d270fde9d9.

    The change needs to be thought out some more, i.e. why isn't
    compute_api.get_all just loading up the image_ref value on the instance
    object rather than calling a helper method from the servers extension to
    the instance object which just calls back to compute_api, seems very
    roundabout, plus isn't it a v3 API issue also?

    Conflicts:
     nova/api/openstack/compute/servers.py

    Due to: 826aed0 Use oslo.i18n

    Change-Id: I6abbfdfa786c3d98065c969e7f9d7d5830caf7e8
    Closes-Bug: #1343689