Remove camelCase or other standards for function names
Bug #1343299 reported by
SirVer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Low
|
Unassigned |
Bug Description
function names in widelands are lowercase and separated by underscores: this_is_
Related branches
lp:~widelands-dev/widelands/bug-1343299
- SirVer: Approve
-
Diff: 25952 lines (+4801/-4801)306 files modifiedsrc/ai/ai_help_structs.cc (+1/-1)
src/ai/ai_help_structs.h (+1/-1)
src/ai/computer_player.cc (+3/-3)
src/ai/computer_player.h (+3/-3)
src/ai/defaultai.cc (+15/-15)
src/base/md5.h (+6/-6)
src/chat/chat.h (+2/-2)
src/economy/cmd_call_economy_balance.cc (+16/-16)
src/economy/cmd_call_economy_balance.h (+2/-2)
src/economy/economy.cc (+7/-7)
src/economy/economy_data_packet.cc (+17/-17)
src/economy/economy_data_packet.h (+2/-2)
src/economy/fleet.cc (+16/-16)
src/economy/portdock.cc (+17/-17)
src/economy/request.cc (+32/-32)
src/economy/request.h (+2/-2)
src/economy/road.cc (+2/-2)
src/economy/road.h (+1/-1)
src/economy/route.cc (+7/-7)
src/economy/route.h (+1/-1)
src/economy/shippingitem.cc (+4/-4)
src/economy/transfer.cc (+5/-5)
src/economy/ware_instance.cc (+14/-14)
src/economy/wares_queue.cc (+20/-20)
src/economy/wares_queue.h (+2/-2)
src/editor/editorinteractive.cc (+1/-1)
src/editor/map_generator.cc (+40/-40)
src/editor/map_generator.h (+5/-5)
src/editor/tools/editor_decrease_resources_tool.cc (+1/-1)
src/editor/tools/editor_increase_resources_tool.cc (+2/-2)
src/editor/tools/editor_increase_resources_tool.h (+1/-1)
src/editor/tools/editor_make_infrastructure_tool.cc (+1/-1)
src/editor/tools/editor_make_infrastructure_tool.h (+1/-1)
src/editor/tools/editor_set_port_space_tool.cc (+3/-3)
src/editor/tools/editor_set_port_space_tool.h (+1/-1)
src/editor/tools/editor_set_resources_tool.cc (+1/-1)
src/editor/tools/editor_set_starting_pos_tool.cc (+2/-2)
src/editor/tools/editor_set_starting_pos_tool.h (+1/-1)
src/editor/ui_menus/editor_main_menu_load_map.cc (+8/-8)
src/editor/ui_menus/editor_main_menu_map_options.cc (+2/-2)
src/editor/ui_menus/editor_main_menu_random_map.cc (+6/-6)
src/editor/ui_menus/editor_main_menu_save_map.cc (+20/-20)
src/editor/ui_menus/editor_main_menu_save_map_make_directory.cc (+1/-1)
src/editor/ui_menus/editor_player_menu.cc (+5/-5)
src/editor/ui_menus/editor_tool_change_resources_options_menu.cc (+1/-1)
src/editor/ui_menus/editor_tool_menu.cc (+1/-1)
src/game_io/game_class_packet.cc (+10/-10)
src/game_io/game_class_packet.h (+2/-2)
src/game_io/game_cmd_queue_packet.cc (+21/-21)
src/game_io/game_cmd_queue_packet.h (+2/-2)
src/game_io/game_data_packet.h (+2/-2)
src/game_io/game_interactive_player_packet.cc (+14/-14)
src/game_io/game_interactive_player_packet.h (+2/-2)
src/game_io/game_loader.cc (+12/-12)
src/game_io/game_map_packet.cc (+6/-6)
src/game_io/game_map_packet.h (+5/-5)
src/game_io/game_player_economies_packet.cc (+15/-15)
src/game_io/game_player_economies_packet.h (+2/-2)
src/game_io/game_player_info_packet.cc (+50/-50)
src/game_io/game_player_info_packet.h (+2/-2)
src/game_io/game_preload_packet.cc (+5/-5)
src/game_io/game_preload_packet.h (+2/-2)
src/game_io/game_saver.cc (+8/-8)
src/graphic/animation.cc (+3/-3)
src/graphic/diranimations.h (+1/-1)
src/graphic/font.cc (+2/-2)
src/graphic/graphic.cc (+3/-3)
src/graphic/image_io.cc (+6/-6)
src/graphic/render/gamerenderer_gl.cc (+2/-2)
src/graphic/render/gl_surface_texture.cc (+2/-2)
src/graphic/render/gl_surface_texture.h (+3/-3)
src/graphic/text/font_io.cc (+2/-2)
src/graphic/text/test/render.cc (+2/-2)
src/graphic/text/test/render_richtext.cc (+2/-2)
src/graphic/texture.cc (+1/-1)
src/graphic/texture.h (+1/-1)
src/io/dedicated_log.cc (+19/-19)
src/io/dedicated_log.h (+1/-1)
src/io/fileread.cc (+20/-20)
src/io/fileread.h (+17/-17)
src/io/filesystem/disk_filesystem.cc (+60/-60)
src/io/filesystem/disk_filesystem.h (+26/-26)
src/io/filesystem/filesystem.cc (+27/-27)
src/io/filesystem/filesystem.h (+31/-31)
src/io/filesystem/layered_filesystem.cc (+72/-71)
src/io/filesystem/layered_filesystem.h (+26/-26)
src/io/filesystem/test/test_filesystem.cc (+7/-7)
src/io/filesystem/zip_exceptions.h (+1/-1)
src/io/filesystem/zip_filesystem.cc (+64/-64)
src/io/filesystem/zip_filesystem.h (+34/-34)
src/io/filewrite.cc (+19/-19)
src/io/filewrite.h (+12/-12)
src/io/machdep.h (+13/-13)
src/io/streamread.cc (+20/-20)
src/io/streamread.h (+15/-15)
src/io/streamwrite.cc (+4/-4)
src/io/streamwrite.h (+29/-29)
src/logic/attackable.h (+1/-1)
src/logic/battle.cc (+32/-32)
src/logic/battle.h (+2/-2)
src/logic/bob.cc (+65/-65)
src/logic/bob.h (+2/-2)
src/logic/buildcost.cc (+6/-6)
src/logic/building.cc (+1/-1)
src/logic/campaign_visibility.cc (+2/-2)
src/logic/carrier.cc (+5/-5)
src/logic/checkstep.cc (+9/-9)
src/logic/checkstep.h (+11/-11)
src/logic/cmd_calculate_statistics.cc (+6/-6)
src/logic/cmd_calculate_statistics.h (+2/-2)
src/logic/cmd_incorporate.cc (+8/-8)
src/logic/cmd_incorporate.h (+2/-2)
src/logic/cmd_luacoroutine.cc (+7/-7)
src/logic/cmd_luacoroutine.h (+2/-2)
src/logic/cmd_luascript.cc (+8/-8)
src/logic/cmd_luascript.h (+2/-2)
src/logic/cmd_queue.cc (+9/-9)
src/logic/cmd_queue.h (+2/-2)
src/logic/critter.cc (+7/-7)
src/logic/editor_game_base.cc (+1/-1)
src/logic/editor_game_base.h (+1/-1)
src/logic/expedition_bootstrap.cc (+12/-12)
src/logic/findbob.cc (+1/-1)
src/logic/findimmovable.cc (+1/-1)
src/logic/game.cc (+54/-54)
src/logic/game.h (+9/-9)
src/logic/game_controller.h (+10/-10)
src/logic/game_settings.h (+29/-29)
src/logic/immovable.cc (+40/-40)
src/logic/instances.cc (+28/-28)
src/logic/instances.h (+4/-4)
src/logic/map.cc (+4/-4)
src/logic/map.h (+4/-4)
src/logic/map_info.cc (+8/-8)
src/logic/message.h (+2/-2)
src/logic/message_id.h (+2/-2)
src/logic/message_queue.h (+1/-1)
src/logic/militarysite.cc (+48/-48)
src/logic/militarysite.h (+14/-14)
src/logic/path.cc (+9/-9)
src/logic/path.h (+1/-1)
src/logic/pathfield.cc (+1/-1)
src/logic/pathfield.h (+1/-1)
src/logic/player.cc (+48/-48)
src/logic/player.h (+7/-7)
src/logic/playercommand.cc (+483/-483)
src/logic/playercommand.h (+60/-60)
src/logic/playersmanager.cc (+3/-3)
src/logic/production_program.cc (+4/-4)
src/logic/productionsite.h (+1/-1)
src/logic/replay.cc (+33/-33)
src/logic/replay.h (+4/-4)
src/logic/replay_game_controller.cc (+12/-12)
src/logic/replay_game_controller.h (+8/-8)
src/logic/requirements.cc (+27/-27)
src/logic/requirements.h (+4/-4)
src/logic/save_handler.cc (+12/-12)
src/logic/ship.cc (+31/-31)
src/logic/single_player_game_controller.cc (+11/-11)
src/logic/single_player_game_controller.h (+8/-8)
src/logic/single_player_game_settings_provider.cc (+43/-43)
src/logic/single_player_game_settings_provider.h (+23/-23)
src/logic/soldier.cc (+54/-54)
src/logic/soldier.h (+7/-7)
src/logic/soldiercontrol.h (+13/-13)
src/logic/trainingsite.cc (+29/-29)
src/logic/trainingsite.h (+11/-11)
src/logic/tribe.cc (+5/-5)
src/logic/warehouse.cc (+14/-14)
src/logic/warehouse.h (+16/-16)
src/logic/widelands.h (+3/-3)
src/logic/widelands_geometry.cc (+2/-2)
src/logic/widelands_geometry.h (+1/-1)
src/logic/widelands_geometry_io.cc (+28/-28)
src/logic/widelands_geometry_io.h (+12/-12)
src/logic/worker.cc (+18/-18)
src/logic/worker.h (+1/-1)
src/logic/worker_descr.cc (+3/-3)
src/logic/worker_descr.h (+1/-1)
src/logic/worker_program.cc (+3/-3)
src/logic/worker_program.h (+1/-1)
src/logic/world/editor_category.cc (+1/-1)
src/logic/world/map_gen.cc (+32/-32)
src/logic/world/map_gen.h (+26/-26)
src/logic/world/terrain_description.cc (+2/-2)
src/map_io/map_allowed_building_types_packet.cc (+2/-2)
src/map_io/map_allowed_worker_types_packet.cc (+2/-2)
src/map_io/map_bob_packet.cc (+10/-10)
src/map_io/map_bob_packet.h (+2/-2)
src/map_io/map_building_packet.cc (+31/-31)
src/map_io/map_building_packet.h (+2/-2)
src/map_io/map_buildingdata_packet.cc (+261/-261)
src/map_io/map_buildingdata_packet.h (+2/-2)
src/map_io/map_data_packet.h (+2/-2)
src/map_io/map_elemental_packet.cc (+4/-4)
src/map_io/map_elemental_packet.h (+3/-3)
src/map_io/map_exploration_packet.cc (+12/-12)
src/map_io/map_extradata_packet.cc (+13/-13)
src/map_io/map_extradata_packet.h (+2/-2)
src/map_io/map_flag_packet.cc (+13/-13)
src/map_io/map_flagdata_packet.cc (+47/-47)
src/map_io/map_heights_packet.cc (+8/-8)
src/map_io/map_message_saver.h (+1/-1)
src/map_io/map_node_ownership_packet.cc (+9/-9)
src/map_io/map_object_packet.cc (+9/-9)
src/map_io/map_object_packet.h (+3/-3)
src/map_io/map_objective_packet.cc (+2/-2)
src/map_io/map_player_names_and_tribes_packet.cc (+4/-4)
src/map_io/map_player_names_and_tribes_packet.h (+3/-3)
src/map_io/map_player_position_packet.cc (+2/-2)
src/map_io/map_players_messages_packet.cc (+5/-5)
src/map_io/map_players_view_packet.cc (+131/-131)
src/map_io/map_port_spaces_packet.cc (+2/-2)
src/map_io/map_port_spaces_packet.h (+3/-3)
src/map_io/map_resources_packet.cc (+18/-18)
src/map_io/map_resources_packet.h (+2/-2)
src/map_io/map_road_packet.cc (+9/-9)
src/map_io/map_roaddata_packet.cc (+55/-55)
src/map_io/map_saver.cc (+25/-25)
src/map_io/map_scripting_packet.cc (+17/-17)
src/map_io/map_terrain_packet.cc (+17/-17)
src/map_io/map_terrain_packet.h (+2/-2)
src/map_io/map_version_packet.cc (+2/-2)
src/map_io/s2map.cc (+14/-14)
src/map_io/widelands_map_loader.cc (+32/-32)
src/network/internet_gaming.cc (+100/-100)
src/network/internet_gaming.h (+7/-7)
src/network/internet_gaming_protocol.h (+41/-41)
src/network/netclient.cc (+206/-206)
src/network/netclient.h (+37/-37)
src/network/nethost.cc (+477/-477)
src/network/nethost.h (+60/-60)
src/network/network.cc (+6/-6)
src/network/network.h (+5/-5)
src/network/network_lan_promotion.cc (+3/-3)
src/network/network_lan_promotion.h (+1/-1)
src/network/network_player_settings_backend.cc (+7/-7)
src/network/network_protocol.h (+50/-50)
src/profile/profile.cc (+10/-10)
src/profile/profile.h (+2/-2)
src/random/random.cc (+8/-8)
src/random/random.h (+2/-2)
src/scripting/lua_coroutine.cc (+8/-8)
src/scripting/lua_game.cc (+8/-8)
src/scripting/lua_map.cc (+7/-7)
src/scripting/lua_path.cc (+4/-4)
src/scripting/lua_root.cc (+2/-2)
src/scripting/lua_ui.cc (+2/-2)
src/scripting/persistence.cc (+5/-5)
src/scripting/scripting.cc (+2/-2)
src/scripting/test/test_luna.cc (+9/-9)
src/sound/songset.cc (+5/-5)
src/sound/sound_handler.cc (+10/-10)
src/sound/sound_handler.h (+0/-1)
src/ui_basic/editbox.cc (+4/-4)
src/ui_basic/editbox.h (+4/-4)
src/ui_basic/helpwindow.cc (+3/-3)
src/ui_basic/helpwindow.h (+1/-1)
src/ui_basic/icon.cc (+3/-3)
src/ui_basic/icon.h (+3/-3)
src/ui_basic/messagebox.cc (+12/-12)
src/ui_basic/messagebox.h (+3/-3)
src/ui_basic/panel.cc (+1/-1)
src/ui_basic/progresswindow.cc (+1/-1)
src/ui_basic/spinbox.cc (+17/-17)
src/ui_basic/spinbox.h (+8/-8)
src/ui_fsmenu/editor_mapselect.cc (+8/-8)
src/ui_fsmenu/internet_lobby.cc (+12/-12)
src/ui_fsmenu/internet_lobby.h (+4/-4)
src/ui_fsmenu/launch_mpg.cc (+34/-34)
src/ui_fsmenu/launch_mpg.h (+1/-1)
src/ui_fsmenu/launch_spg.cc (+20/-20)
src/ui_fsmenu/loadgame.cc (+11/-11)
src/ui_fsmenu/loadreplay.cc (+5/-5)
src/ui_fsmenu/mapselect.cc (+5/-5)
src/ui_fsmenu/multiplayer.cc (+5/-5)
src/ui_fsmenu/multiplayer.h (+2/-2)
src/ui_fsmenu/netsetup_lan.cc (+3/-3)
src/ui_fsmenu/options.cc (+12/-12)
src/wlapplication.cc (+23/-23)
src/wui/attack_box.cc (+1/-1)
src/wui/chatoverlay.cc (+6/-6)
src/wui/chatoverlay.h (+1/-1)
src/wui/debugconsole.cc (+2/-2)
src/wui/debugconsole.h (+2/-2)
src/wui/encyclopedia_window.cc (+6/-6)
src/wui/encyclopedia_window.h (+3/-3)
src/wui/fieldaction.cc (+13/-13)
src/wui/game_chat_menu.cc (+1/-1)
src/wui/game_debug_ui.cc (+2/-2)
src/wui/game_main_menu_save_game.cc (+14/-14)
src/wui/gamechatpanel.cc (+9/-9)
src/wui/gamechatpanel.h (+4/-4)
src/wui/interactive_base.cc (+19/-19)
src/wui/interactive_base.h (+2/-2)
src/wui/interactive_gamebase.cc (+1/-1)
src/wui/interactive_player.cc (+4/-4)
src/wui/itemwaresdisplay.cc (+8/-8)
src/wui/itemwaresdisplay.h (+3/-3)
src/wui/login_box.cc (+6/-6)
src/wui/login_box.h (+2/-2)
src/wui/multiplayersetupgroup.cc (+9/-9)
src/wui/playerdescrgroup.cc (+10/-10)
src/wui/soldiercapacitycontrol.cc (+3/-3)
src/wui/soldierlist.cc (+7/-7)
src/wui/waresdisplay.cc (+1/-1)
tags: | added: cleanups lowhangingfruit |
Changed in widelands: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in widelands: | |
status: | Confirmed → In Progress |
assignee: | nobody → GunChleoc (gunchleoc) |
Changed in widelands: | |
status: | In Progress → Fix Committed |
milestone: | none → build19-rc1 |
Changed in widelands: | |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I have a function nam that I don't know what to do with, because I have no idea what it means.
Mix_Chunk * RWopsify_ MixLoadWAV( FileRead &); in sound_handler.h
It doesn't seem to be used either, can I delete it?