Wrong behavior during update port resource

[Sergey Kraynev]

Current update for port resource does not work correct. The simplest example is:

- Create stack with one port resource:

heat_template_version: 2013-05-23
resources:

  port1:
    type: OS::Neutron::Port
    properties:
      name: some_name
      network: 28c0150c-2d5d-42ae-ad4c-c8f066310e09

- Then remove name property from port definition and update stack.
- You will see , that port will lose his ip address.

It may be dangerous when in case when you use this port as instance interface (you will lose ability to connect to your instance).

The cause of this problem is follow:

When we do create we send all properties include "fixed_ips" that has default value equal [].
It should be fixed same way such as for handle_create.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/107652

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/107652
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=01f8e67fdb2964931f2489d14b112519c36de875
Submitter: Jenkins
Branch: master

commit 01f8e67fdb2964931f2489d14b112519c36de875
Author: Sergey Kraynev <email address hidden>
Date: Thu Jul 17 07:16:50 2014 -0400

    Fix updating for OS::Neutron::Port resource

    Updating of port resource should not lead to removing ip address.
    This patch includes next changes:
    - Fix update behavior for Port resource.
    - Using properties names instead of constant names.
    - New test was added for port create/update actions.

    Change-Id: Iff73aaaa433ac56515a931f83ad201d15fca2bd8
    Closes-Bug: #1343166