Building help is broken (get_worker_description string expected got table)

Bug #1342801 reported by Hans Joachim Desserud
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned

Bug Description

Steps to reproduce:
1. Start a new game.
2. Build a building.
3. Open the building window.
4. Click on the button marked with a question mark

Expected result:
Shown a window with help/explanation/details on the building.

Actual result:

"scripting/format_help.lua":708: bad argument #2 to get_worker_description' (string expected, got table)

From what I can see affects all tribes and any building. Not sure how recently this broke, but 7103 had some major changes in this department.

Widelands r7105 on Ubuntu 14.04.

Tags: help lua

Related branches

Changed in widelands:
importance: Undecided → Medium
milestone: none → build19-rc1
tags: added: help lua
GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
GunChleoc (gunchleoc)
Changed in widelands:
status: New → In Progress
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed - thanks for catching this.

Revision history for this message
SirVer (sirver) wrote :

that was my bad - I changed the behavivor of inputs() and workers(), fixed the tests, but not the users. Sorry.

Fix in r7109.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Shit happens - and since I know this particular Lua file best, it made sense for me to fix it.

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Fixed again now. :)

Changed in widelands:
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.