If network test is unconfigured, error message in output refers to the wrong configuration file

[Rod Smith]

Since Ubuntu 14.04, the network test configuration has moved to /etc/xdg/canonical-certification.conf from /etc/checkbox.d/network.cfg; however, if the user somehow forgets to edit the former file, the error message in results.html and submission.xml refers to the latter location, as in the following from submission.xml:

    <question name="ethernet/multi_nic_eth2">
      <answer type="multiple_choice">fail</answer>
      <answer_choices>
        <value type="str">none</value>
        <value type="str">pass</value>
        <value type="str">fail</value>
        <value type="str">skip</value>
      </answer_choices>
      <comment>ERROR:root:Please supply target via: /etc/checkbox.d/network.cfg
</comment>
    </question>

This is with checkbox-ng version 0.6+bzr3120+pkg9~ubuntu14.04.1 and plainbox-provider-certification-server 0.3+bzr3120+pkg19~ubuntu14.04.1

[Daniel Manrique (roadmr)]

Now that we no longer need to keep backwards compatibility with checkbox old stack, we could simply remove support for that hideous file. I'll do so and also provide better messages on what's wrong and how to configure this.

$ bin/network test -i wlan0
ERROR:root:Target server has not been supplied.
INFO:root:Target server can be configured 3 different ways:
INFO:root:1- If calling the script directly, pass the --target option
INFO:root:2- Define the TEST_TARGET_IPERF environment variable
INFO:root:3- (If running the test via checkbox, define the target in /etc/xdg/canonical-certification.conf)
INFO:root:Please run this script with -h to see more details on how to configure