IPv4 address sorting is nonsensical

Bug #1342266 reported by Nicolas Simonds
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Nicolas Simonds

Bug Description

Horizon uses the default IP address sorter provided with jquery-tablesorter, which was apparently written by throwing tennis balls at a keyboard from across the room and saving the results. It gets things preposterously wrong.

To Reproduce:

1. Create a bunch of VMs on a large-ish network, say a /23 or /21
2. Sort the Instances DataTable by IP address

Expected Behavior:

Sensible sorting by IP address.

Actual Behaviour:

Hilarity ensues. Screenshot attached.

Revision history for this message
Nicolas Simonds (nicolas.simonds) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/107140

Changed in horizon:
assignee: nobody → Nicolas Simonds (nicolas.simonds)
status: New → In Progress
description: updated
Revision history for this message
Thai Tran (tqtran) wrote :

Nick's fix seems to not work. Where is the reason why that might be.

David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Low
milestone: none → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/107140
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7b68ebe2e34ed9d0a1ea0672721c397b9d3f4106
Submitter: Jenkins
Branch: master

commit 7b68ebe2e34ed9d0a1ea0672721c397b9d3f4106
Author: Nicolas Simonds <email address hidden>
Date: Tue Jul 15 11:25:14 2014 -0700

    Add a proper IPv4 sorter for jquery-tablesort

    The default implementation provided with tablesorter uses a busted
    regex and nonsensical formatter. Add an explicit IPv4 parser/formatter
    to Horizon and use it instead.

    Closes-Bug: 1342266
    Change-Id: I13c709f6171f8e7214b8a3ef15ddf441806df4c2

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.