Fuel for OpenStack

[grunt bower] Fatal error: Arguments to path.join must be strings

Bug #1341156 reported by Aleksandra Fedorova on 2014-07-12

This bug affects 3 people

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Fix Released	Critical	Vitaly Kramskikh	Fuel for OpenStack 5.1
4.1.x	Fix Committed	Critical	Vitaly Kramskikh	Fuel for OpenStack 4.1.1-updates
5.0.x	Fix Released	Critical	Vitaly Kramskikh	Fuel for OpenStack 5.0.1

Bug Description

Ubuntu 14.04, master branch for fuel-web

We cannot build nailgun package for fuel iso, due to the error:

Fatal error: Arguments to path.join must be strings

fuel@ubuntu-test:~/Fuel/fuel-web/nailgun$ npm --version
1.3.10
fuel@ubuntu-test:~/Fuel/fuel-web/nailgun$ grunt --version
grunt-cli v0.1.13
grunt v0.4.5

fuel@ubuntu-test:~/Fuel/fuel-web/nailgun$ grunt bower
Running "bower:install" (bower) task
bower not-cached git://github.com/guybedford/require-css.git#0.1.0
bower resolve git://github.com/guybedford/require-css.git#0.1.0
bower not-cached git://github.com/lodash/lodash.git#1.3.1
bower resolve git://github.com/lodash/lodash.git#1.3.1
bower not-cached git://github.com/BobKnothe/autoNumeric.git#1.9.12
bower resolve git://github.com/BobKnothe/autoNumeric.git#1.9.12
bower not-cached git://github.com/NYTimes/backbone.stickit.git#0.7.0
bower resolve git://github.com/NYTimes/backbone.stickit.git#0.7.0
bower not-cached git://github.com/jeromegn/Backbone.localStorage.git#1.1.7
bower resolve git://github.com/jeromegn/Backbone.localStorage.git#1.1.7
bower not-cached git://github.com/onsi/cocktail.git#0.5.7
bower resolve git://github.com/onsi/cocktail.git#0.5.7
bower not-cached git://github.com/jamuhl/i18next.git#1.7.1
bower resolve git://github.com/jamuhl/i18next.git#1.7.1
bower not-cached git://github.com/powmedia/backbone-deep-model.git#0.10.4
bower resolve git://github.com/powmedia/backbone-deep-model.git#0.10.4
bower not-cached git://github.com/less/less.git#1.5.1
bower resolve git://github.com/less/less.git#1.5.1
bower not-cached git://github.com/jquery/jquery.git#1.9.1
bower resolve git://github.com/jquery/jquery.git#1.9.1
bower not-cached git://github.com/jrburke/requirejs-bower.git#2.1.9
bower resolve git://github.com/jrburke/requirejs-bower.git#2.1.9
bower not-cached git://github.com/requirejs/text.git#2.0.10
bower resolve git://github.com/requirejs/text.git#2.0.10
Fatal error: Arguments to path.join must be strings

Tags:

Revision history for this message

Aleksandra Fedorova (bookwar) wrote on 2014-07-12:

npm install log Edit (60.9 KiB, text/plain)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-12: Related fix proposed to fuel-web (stable/5.0)

Related fix proposed to branch: stable/5.0
Review: https://review.openstack.org/106582

Revision history for this message

Aleksandra Fedorova (bookwar) wrote on 2014-07-12:

If we backport this patch, bower will use cached data and won't try to update it with latest versions from github.

This will resolve the current problem for fuel-5.0 builds.

Changed in fuel:
milestone:	none → 5.0.1
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-12: Related fix merged to fuel-web (stable/5.0)

Reviewed: https://review.openstack.org/106582
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4637ae61920b92f56154a03f7e717e3bd597525c
Submitter: Jenkins
Branch: stable/5.0

commit 4637ae61920b92f56154a03f7e717e3bd597525c
Author: Vitaly Kramskikh <email address hidden>
Date: Thu May 22 18:56:08 2014 +0400

Remove all direct HTTP links to bower packages

    Change-Id: Id1ef0cb909157dabaf8ffe962fdf78fa526abab5
    Related-Bug: #1311265
    Related-Bug: #1341156
    (cherry picked from commit 8f6cc2be2d54ee2094d4f5447c1ceef7e13e096f)

Revision history for this message

Vitaly Kramskikh (vkramskikh) wrote on 2014-07-14:

After merging the patch, is bug still exist?

Revision history for this message

Aleksandra Fedorova (bookwar) wrote on 2014-07-14:

Seems to be working now. Should we backport it to 4.1 as well?

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-14: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106739

Changed in fuel:
assignee:	Fuel UI Team (fuel-ui) → Vitaly Kramskikh (vkramskikh)
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-14: Fix proposed to fuel-web (stable/5.0)

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/106758

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-14: Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/106739
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=a400032f0326b767ae2505b497fba9ee202ed9b4
Submitter: Jenkins
Branch: master

commit a400032f0326b767ae2505b497fba9ee202ed9b4
Author: Vitaly Kramskikh <email address hidden>
Date: Mon Jul 14 15:42:44 2014 +0400

Added npm-shrinkwrap.json to lock down package versions

    Also overrides version of bower for grunt-bower-task,
    because all bowers <1.3.8 became buggy.
    See https://github.com/bower/bower/pull/1403

Change-Id: I24fb24967b4870b5c6291b3f48451ef69e0bbe44
Closes-Bug: 1341156

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-14: Fix merged to fuel-web (stable/5.0)

#10

Reviewed: https://review.openstack.org/106758
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=3b347e9c6a08bb30d85a122398eacd605fb62305
Submitter: Jenkins
Branch: stable/5.0

commit 3b347e9c6a08bb30d85a122398eacd605fb62305
Author: Vitaly Kramskikh <email address hidden>
Date: Mon Jul 14 15:42:44 2014 +0400

Added npm-shrinkwrap.json to lock down package versions

    Also overrides version of bower for grunt-bower-task,
    because all bowers <1.3.8 became buggy.
    See https://github.com/bower/bower/pull/1403

Change-Id: I24fb24967b4870b5c6291b3f48451ef69e0bbe44
Closes-Bug: 1341156

Revision history for this message

Miroslav Anashkin (manashkin) wrote on 2014-07-14:

#11

Same bug reported against 4.1.1 build process. Please back port to all affected Fuel branches.

Hey Michael

Our config.mk only has the following changes in it:

FUELLIB_COMMIT?=tags/4.1.1
NAILGUN_COMMIT?=tags/4.1.1
ASTUTE_COMMIT?=tags/4.1.1
OSTF_COMMIT?=tags/4.1.1

Everything else is as per the repo.
Trying to build a new ISO and keep getting the following error:

Same bug reported against 4.1.1 build process. Please back port to all affected Fuel branches.

Hey Michael

Our config.mk only has the following changes in it:

FUELLIB_COMMIT?=tags/4.1.1
NAILGUN_COMMIT?=tags/4.1.1
ASTUTE_COMMIT?=tags/4.1.1
OSTF_COMMIT?=tags/4.1.1

Everything else is as per the repo.
Trying to build a new ISO and keep getting the following error:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-15: Fix proposed to fuel-web (stable/4.1)

#13

Fix proposed to branch: stable/4.1
Review: https://review.openstack.org/107043

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-15: Fix merged to fuel-web (stable/4.1)

#14

Reviewed: https://review.openstack.org/107043
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=8cc1dff8ab43f50bd28a9c081d7d06fbd3831b98
Submitter: Jenkins
Branch: stable/4.1

commit 8cc1dff8ab43f50bd28a9c081d7d06fbd3831b98
Author: Vitaly Kramskikh <email address hidden>
Date: Mon Jul 14 15:42:44 2014 +0400

Added npm-shrinkwrap.json to lock down package versions

    Also overrides version of bower for grunt-bower-task,
    because all bowers <1.3.8 became buggy.
    See https://github.com/bower/bower/pull/1403

Change-Id: I24fb24967b4870b5c6291b3f48451ef69e0bbe44
Closes-Bug: 1341156

Dmitry Pyzhov (dpyzhov) on 2014-08-13

no longer affects:

fuel/5.1.x