test.network.statistics.test_statistics:test_get_samples_one_driver_two_resource uses wrong timestamp

Bug #1341142 reported by Chris Dent
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Chris Dent

Bug Description

The first sample is using the third timestamp, this means there is a very slim chance that the timestamp will be incorrect. Most of the time is okay because all of the created timestamps are in the same second, but in rare circumstances the second and/or third timestamp may be different from the first.

This appears to be a simple typo.

Discovered because of a failure on https://review.openstack.org/#/c/106385/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106564

Changed in ceilometer:
assignee: nobody → Chris Dent (chdent)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/106564
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=dac40f8297d1f291419dfae17c79084a272a5c5e
Submitter: Jenkins
Branch: master

commit dac40f8297d1f291419dfae17c79084a272a5c5e
Author: Chris Dent <email address hidden>
Date: Sat Jul 12 16:19:58 2014 +0100

    Fix incorrect use of timestamp in test

    The timestamp used has a very slim chance of being in
    a different second than actually desired which would
    tickle the bug. The bug itself is simply that the
    mapping between sample and timestamp was incorrect.

    To make sure that there isn't confusion over distinct
    timestamps, _make_timestamps has been changed so that
    if multiple timestamps are requested, each is a second
    after the previous.

    Change-Id: I22d999c506a30d4ca6b8dd7e9de501570257b99e
    Closes-bug: 1341142

Changed in ceilometer:
status: In Progress → Fix Committed
Eoghan Glynn (eglynn)
Changed in ceilometer:
importance: Undecided → Medium
milestone: none → juno-2
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.