Building help: remove logic from wrappers

[GunChleoc]

This bug will need attention after https://code.launchpad.net/~widelands-dev/widelands/bug-1074353 has been merged.

The following properties in lua_map.cc contain programming logic:

L_WareDescription::get_producers
L_WareDescription::get_consumers

catch-22: If I fill up the list in the constructor of WareDescr, the tribe's buildings haven't been parsed yet. If I fill it up later, I can't make it const, which then blows up in lua_map.cc.

Any ideas?

Comment from SirVer:

> How would I get it from there into the constructor of the WareDescr, which have already been parsed and constructed by this point?

You don't. You get the (mutable) wares_description container from the tribe_description into the building constructor and add a member (mutable_ware_description(), either in Tribe_Descr or if there is a container with every ware in there than there). So you can get something like this in the buildingdesc constructor:

tribe.mutable_ware_description("log")->add_producer(*this);

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.