[library] network namespaces require net.ipv4.ip_forward

[Andrew Woodward]

any usage of a network namespace requires net.ipv4.ip_forward = 1, however we are simply lucky that its enabled as some of the uses don't have it defined. We need to add more uses of:

  if !defined(Sysctl::Value['net.ipv4.ip_forward']) {
    sysctl::value { 'net.ipv4.ip_forward': value => '1'}
  }

to the manifests where it is required so that it won't be missed if the components are separated more.

currently the network role entry point into puppet-neutron use this, but ns_IPaddr2 needs it, and probably each puppet-neutron service that run in network namespaces.

[Bogdan Dobrelya (bogdando)]

Checking if the value was defined is an overkill, puppet ensures it *will* be by its declarative nature, e.g. like for this case https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/openstack/manifests/keepalive.pp

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/107046
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=0c60c1935b9d29d46bbb0080f7f30bc387294cb7
Submitter: Jenkins
Branch: master

commit 0c60c1935b9d29d46bbb0080f7f30bc387294cb7
Author: Sergey Vasilenko <email address hidden>
Date: Tue Jul 15 17:18:15 2014 +0400

    Setup IP forwarding in base system for ns_IPaddr2 resources

    Closes-bug: #1342073
    Closes-bug: #1340968

    Change-Id: I9aeafdd458aab0545ec08a01f43e39f0499b020d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/116854

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116854
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=f0ec746f42336e1a192cd3043ed43aaf4273912e
Submitter: Jenkins
Branch: stable/5.0

commit f0ec746f42336e1a192cd3043ed43aaf4273912e
Author: Sergey Vasilenko <email address hidden>
Date: Tue Jul 15 17:18:15 2014 +0400

    Setup IP forwarding in base system for ns_IPaddr2 resources

    Closes-bug: #1342073
    Closes-bug: #1340968

    Change-Id: I9aeafdd458aab0545ec08a01f43e39f0499b020d
    (cherry picked from commit 0c60c1935b9d29d46bbb0080f7f30bc387294cb7)