FUEL web UI incorrectly validate vcenter cluster names that contain space chars

Bug #1340886 reported by Igor Zinovik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Igor Zinovik

Bug Description

VMware vCenter allows use of space characters in cluster names, e.g. "my dev cluster".
Right now FUEL web UI incorrectly validates such names. Regular expression that check names must be fixed.

$ nailgun/nailgun/fixtures/openstack.yaml
...
214 description: "vCenter cluster name. If you have multiple clusters, use comma separated names."
215 weight: 40
216 type: "text"
217 regex:
218 source: '^([\d\w_-]+[ ]*[\d\w_-]+)(,[\d\w_-]+[ ]*[\d\w_-]+)*$' <- FIX RE
219 error: "Invalid clusters list"

Revision history for this message
Igor Zinovik (izinovik) wrote :
description: updated
description: updated
Revision history for this message
Igor Zinovik (izinovik) wrote :

BTW it does not allow to specify cluster name that consists of single char, like 'a' or '1'.
Specifying string 'a,b,c' is also not validated.

Changed in fuel:
importance: Undecided → High
assignee: nobody → Fuel UI Team (fuel-ui)
milestone: none → 5.1
Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Igor Zinovik (izinovik)
status: New → In Progress
Revision history for this message
Igor Zinovik (izinovik) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/106711
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=d2fe280229515d0e550bb3d23bb6aa8961eee3c6
Submitter: Jenkins
Branch: master

commit d2fe280229515d0e550bb3d23bb6aa8961eee3c6
Author: Igor Zinovik <email address hidden>
Date: Mon Jul 14 12:55:42 2014 +0400

    Correct RE that validates vCenter cluster names

    - match cluster names that include metachars (!@#$%^&*()_+{}:"<>?)
      e.g. 'cluster No.42'
    - right now cluster names with comma are not supported
    - adjust message a little, while here

    Change-Id: Ic36e70ff0d0bc7bd3d23ce9cc633cec6a18df581
    Closes-Bug: 1340886

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.