importing neutron/tests/unit/services/vpn/device_drivers/_test_cisco_csr_rest.py causes program to exit prematurely

Bug #1340881 reported by Joe Gordon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Joe Gordon

Bug Description

https://review.openstack.org/#/c/103675/5/neutron/tests/unit/services/vpn/device_drivers/_test_cisco_csr_rest.py

https://review.openstack.org/#/c/103675/5

neutron/tests/unit/services/vpn/device_drivers/_test_cisco_csr_rest.py

try:
    import httmock
except (NameError, ImportError):
    exit()
import requests

since httmock is not in requirements, importing this module causes whatever imports it to suddenly exit with a return code of 0.

This has disabled flake8, and is possibly breaking unit tests as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106455

Changed in neutron:
assignee: nobody → Joe Gordon (jogo)
status: New → In Progress
Joe Gordon (jogo)
Changed in neutron:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/106455
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b74a38cb11024441e5774c8a8eb8b916bf414e0f
Submitter: Jenkins
Branch: master

commit b74a38cb11024441e5774c8a8eb8b916bf414e0f
Author: Joe Gordon <email address hidden>
Date: Fri Jul 11 18:02:54 2014 +0000

    Revert "VPNaaS REST Client UT Broken"

    I8badc249ad021fdbdb2367b5416c72435ed58994 causes anything importing
    neutron/tests/unit/services/vpn/device_drivers/_test_cisco_csr_rest.py
    to exit since httmock isn't a dependency.

    Fix all hacking issues in addition to the revert, as this patch fixes 'tox -epep8'.
    And just a reverting the patch will cause pep8 to fail.

    Fixes-Bug: #1340881

    This reverts commit 7f0a8f09ab7867100081a898347a5f901e5a442b.

    Change-Id: I373a8c8ab16eb387be6a451b8146642389081afa

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.