Consistent handling of choiceField in trove

Bug #1340867 reported by Andrew Bramley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Andrew Bramley

Bug Description

There appears to be a sort of standard way to populate choiceField such that:

If the choice field list has items then the initial value will be 'Select <object type>'

and if the choice field list is empty then the value will be 'No <object type>s available'

In the Trove Launch dialog we don't do this for the Restore From Backup choiceFIeld - instead it just contains an initial '-'

Change the trove launch dialog restore from backup choice list to follow the preferred pattern using 'Select backup' and 'No backups available'

Andrew Bramley (andrlw)
Changed in horizon:
assignee: nobody → Andrew Bramley (andrlw)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106452

Changed in horizon:
status: New → In Progress
Andrew Bramley (andrlw)
summary: - Consistent handling of choiceFIeld in trove
+ Consistent handling of choiceField in trove
Changed in horizon:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/106452
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=047e5af10823c00e52d641d3ab1f597f26aa932b
Submitter: Jenkins
Branch: master

commit 047e5af10823c00e52d641d3ab1f597f26aa932b
Author: Andrew Bramley <email address hidden>
Date: Fri Jul 11 13:41:32 2014 -0400

    Consistent handling of choiceField for backups

    CHanged the way we initially populate the restore
    backups choice field in the trove launch dialog
    so that it is consistent with other choice fields
    in horizon dashboard e.g. compute->instances

    An empty choiceField now says
    'No backups available'
    and a populated choiceFIeld will have an initial
    selection of
    'Select backup'

    Change-Id: I1b0f57656bd649ad92268789f35c9ba77223dbc9
    Closes-bug: #1340867

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.