Tests fail due to novaclient 2.18 update

Bug #1340596 reported by Matthias Runge
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Matthias Runge
OpenStack Heat
Invalid
Undecided
Unassigned
Icehouse
Fix Released
Undecided
Matthias Runge
python-novaclient
Fix Released
Critical
Russell Bryant

Bug Description

tests currently fail on stable branches:
2014-07-11 07:14:28.737 | ======================================================================
2014-07-11 07:14:28.738 | ERROR: test_index (openstack_dashboard.dashboards.admin.aggregates.tests.AggregatesViewTests)
2014-07-11 07:14:28.774 | ----------------------------------------------------------------------
2014-07-11 07:14:28.775 | Traceback (most recent call last):
2014-07-11 07:14:28.775 | File "/home/jenkins/workspace/gate-horizon-python26/openstack_dashboard/test/helpers.py", line 124, in setUp
2014-07-11 07:14:28.775 | test_utils.load_test_data(self)
2014-07-11 07:14:28.775 | File "/home/jenkins/workspace/gate-horizon-python26/openstack_dashboard/test/test_data/utils.py", line 43, in load_test_data
2014-07-11 07:14:28.775 | data_func(load_onto)
2014-07-11 07:14:28.775 | File "/home/jenkins/workspace/gate-horizon-python26/openstack_dashboard/test/test_data/exceptions.py", line 60, in data
2014-07-11 07:14:28.776 | TEST.exceptions.nova_unauthorized = create_stubbed_exception(nova_unauth)
2014-07-11 07:14:28.776 | File "/home/jenkins/workspace/gate-horizon-python26/openstack_dashboard/test/test_data/exceptions.py", line 44, in create_stubbed_exception
2014-07-11 07:14:28.776 | return cls(status_code, msg)
2014-07-11 07:14:28.776 | File "/home/jenkins/workspace/gate-horizon-python26/openstack_dashboard/test/test_data/exceptions.py", line 31, in fake_init_exception
2014-07-11 07:14:28.776 | self.code = code
2014-07-11 07:14:28.776 | AttributeError: can't set attribute
2014-07-11 07:14:28.777 |

Matthias Runge (mrunge)
Changed in horizon:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/106310

Changed in horizon:
assignee: nobody → Matthias Runge (mrunge)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106311

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/icehouse)

Change abandoned by Matthias Runge (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/106310
Reason: submit to master first, then backport

Matthias Runge (mrunge)
summary: - tests in stable branches fail due updated novalient
+ tests fail due updated novalient
Revision history for this message
Thierry Carrez (ttx) wrote :
summary: - tests fail due updated novalient
+ Tests fail due to novaclient 2.18 update
Changed in heat:
status: New → Invalid
David Lyle (david-lyle)
Changed in horizon:
milestone: none → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/106311
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=322004f8480e40af5e77ed843ff803005d5af27c
Submitter: Jenkins
Branch: master

commit 322004f8480e40af5e77ed843ff803005d5af27c
Author: Matthias Runge <email address hidden>
Date: Fri Jul 11 12:45:19 2014 +0200

    adapt to python-novaclient-2.18.0

    Novaclient renamed HTTPNotImplemented to HttpNotImplemented
    and changed the attribute code to status in exceptions

    This change should make the code work on newer and older versions.

    Change-Id: Ifef6c4c1b2924b03df00f427cfe3e6a7f415e569
    Closes-Bug: #1340596

Changed in horizon:
status: In Progress → Fix Committed
Changed in python-novaclient:
assignee: nobody → Russell Bryant (russellb)
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/106446
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=e14f9741a6fedc2ed4cddd304b2f86378b707575
Submitter: Jenkins
Branch: master

commit e14f9741a6fedc2ed4cddd304b2f86378b707575
Author: Russell Bryant <email address hidden>
Date: Fri Jul 11 13:29:34 2014 -0400

    Revert "Set default http-based exception as `HttpError`"

    This reverts commit 4e1ee661083bd672a884fd13fdb1ffaadea5252a.

    This change is a part of a series that is not backwards compatible,
    and caused breakage in applications that use the client library.

    Change-Id: If614826fb0832602110c1ac8be2c0e6324a5a248
    Partial-Bug: #1340596

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/106724

Changed in python-novaclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/106447
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=d678dd2955f4976e953d727c6f5a6bcfae59c2dc
Submitter: Jenkins
Branch: master

commit d678dd2955f4976e953d727c6f5a6bcfae59c2dc
Author: Russell Bryant <email address hidden>
Date: Fri Jul 11 13:31:14 2014 -0400

    Revert "Reuse exceptions from Oslo"

    This reverts commit 3bde9c3f427110dae3480644752f49b79ac66ec5.

    This change is a part of a series that is not backwards compatible.
    It broke applications using the client library.

    Change-Id: Id01a0a0feb601539d3855f445ebaf6a3cc000610
    Partial-Bug: #1340596

Michael Still (mikal)
Changed in python-novaclient:
status: In Progress → Fix Committed
milestone: none → 2.18.1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/icehouse)

Reviewed: https://review.openstack.org/106724
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=937436f95c9311db9f907051e56a609040f572b0
Submitter: Jenkins
Branch: stable/icehouse

commit 937436f95c9311db9f907051e56a609040f572b0
Author: Matthias Runge <email address hidden>
Date: Fri Jul 11 12:45:19 2014 +0200

    adapt to python-novaclient-2.18.0

    Novaclient renamed HTTPNotImplemented to HttpNotImplemented
    and changed the attribute code to status in exceptions

    This change should make the code work on newer and older versions.

    Closes-Bug: #1340596
    (cherry picked from commit 322004f8480e40af5e77ed843ff803005d5af27c)

    Conflicts:
     openstack_dashboard/dashboards/project/instances/console.py
     openstack_dashboard/test/test_data/exceptions.py

    Change-Id: Ifef6c4c1b2924b03df00f427cfe3e6a7f415e569

Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
Thomas Herve (therve)
no longer affects: heat/havana
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.