NSX: Remove unneed call to _ensure_default_security_group

Bug #1340536 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Aaron Rosen
Icehouse
Fix Released
Undecided
Unassigned

Bug Description

This patch removes an unneeded call to _ensure_default_security_group
which does not need to be called in create_security_group_rule_bulk()
as one would need to call get_security_groups() to look up the uuid
of the default security group which would create it for us.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106284

Changed in neutron:
assignee: nobody → Aaron Rosen (arosen)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/106284
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e2dac9daf39d9b519df14441bbeb99c3c4a7bfaa
Submitter: Jenkins
Branch: master

commit e2dac9daf39d9b519df14441bbeb99c3c4a7bfaa
Author: Aaron Rosen <email address hidden>
Date: Thu Jul 10 23:17:23 2014 -0700

    NSX: Remove unneed call to _ensure_default_security_group

    This patch removes an unneeded call to _ensure_default_security_group
    which does not need to be called in create_security_group_rule_bulk()
    as one would need to call get_security_groups() to look up the uuid
    of the default security group which be would created it for us, BOOM!

    Change-Id: I628a94c7ea9553dcefa68fa956f25244f0abbb18
    Closes-bug: 1340536

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/108533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/108533
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9dcc47644369c562f341507132ef3dfc72369105
Submitter: Jenkins
Branch: stable/icehouse

commit 9dcc47644369c562f341507132ef3dfc72369105
Author: Aaron Rosen <email address hidden>
Date: Thu Jul 10 23:17:23 2014 -0700

    NSX: Remove unneed call to _ensure_default_security_group

    This patch removes an unneeded call to _ensure_default_security_group
    which does not need to be called in create_security_group_rule_bulk()
    as one would need to call get_security_groups() to look up the uuid
    of the default security group which be would created it for us, BOOM!

    Change-Id: I628a94c7ea9553dcefa68fa956f25244f0abbb18
    Closes-bug: 1340536
    (cherry picked from commit e2dac9daf39d9b519df14441bbeb99c3c4a7bfaa)

tags: added: in-stable-icehouse
Changed in neutron:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.