solum assembly delete does not delete heat-stack/nova instance on failure

[Paul Czarkowski]

I create an assembly but nova fails to launch a VM because the scheduler doesn't find a valid host ( not enough memory ).

I then delete that assembly which succeeds, but the resultant heat stack and nova instance remain ( in a failed state ).

agrant@devstack:~/devstack$ solum assembly list
+--------------------------------------+-------+-------------+--------+
| uuid | name | description | status |
+--------------------------------------+-------+-------------+--------+
| b7c9242c-faf0-4b1a-9b4a-7c0e79e2960b | osatx | None | ERROR |
+--------------------------------------+-------+-------------+--------+
vagrant@devstack:~/devstack$ solum assembly delete b7c9242c-faf0-4b1a-9b4a-7c0e79e2960b
vagrant@devstack:~/devstack$ nova list
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
| 2888e764-ef8d-4f58-9a6d-1a6d5864648e | osatx | ERROR | - | NOSTATE | private=10.0.0.2, 172.24.4.3 |
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
vagrant@devstack:~/devstack$ nova list
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
| 2888e764-ef8d-4f58-9a6d-1a6d5864648e | osatx | ERROR | - | NOSTATE | private=10.0.0.2, 172.24.4.3 |
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
vagrant@devstack:~/devstack$ nova list
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
| 2888e764-ef8d-4f58-9a6d-1a6d5864648e | osatx | ERROR | - | NOSTATE | private=10.0.0.2, 172.24.4.3 |
+--------------------------------------+-------+--------+------------+-------------+------------------------------+
vagrant@devstack:~/devstack$ heat stack-list
+--------------------------------------+--------------------------------------------+---------------+----------------------+
| id | stack_name | stack_status | creation_time |
+--------------------------------------+--------------------------------------------+---------------+----------------------+
| d06cd411-30fb-4b33-9592-f11d0757f286 | osatx-b7c9242c-faf0-4b1a-9b4a-7c0e79e2960b | CREATE_FAILED | 2014-07-10T16:44:54Z |
+--------------------------------------+--------------------------------------------+---------------+----------------------+
vagrant@devstack:~/devstack$ solum assembly list
+------+------+-------------+--------+
| uuid | name | description | status |
+------+------+-------------+--------+
+------+------+-------------+--------+

[Adrian Otto (aotto)]

Instead of accumulating orphaned resources, we should delete them, and leave only the assembly in a failed state.

[Devdatta Kulkarni (devdatta-kulkarni)]

Tracking this as part of:

https://bugs.launchpad.net/solum/+bug/1517588