[Network Menu] Enabling flight mode still shows the wifi icon

[Brendan Donegan]

Ubuntu 15.04 r82

On a phone where Flight Mode is off and wi-fi is on:
1. Turn on Flight Mode.

What happens: The wi-fi icon remains in the indicator.

What should happen: The wi-fi icon goes away.

<https://wiki.ubuntu.com/Networking#Title>: "On the phone ... the title ... should consist of: Flight Mode indication: ✈ the Flight Mode icon, if Flight Mode is on, otherwise nothing at all. ... Finally, Wi-Fi status indication: ... nothing at all"

[Antti Kaijanmäki (kaijanmaki)]

This is fixed for the cellular icons, but not for Wi-Fi.

[Antti Kaijanmäki (kaijanmaki)]

Actually we have to show _something_ as we might end up in a situation where there is no icons shown by the indicator (just go through the spec and always take the "nothing at all" option). And if an indicator shows no icons it can't be opened.

I would always prefer to have the "no-connection" icon visible if there indeed is no connection. But I could also implement this in a way that _if_ there are no other icons then I show the "no-connection".

Also I don't know if the no-connection icon should be changed to something else to distinct it from "wifi on, but not connected"

[Matthew Paul Thomas (mpt)]

Per spec, the only circumstance in which the network indicator has no icons is when all these are true: (1) Flight Mode is off; (2) the modem is unregistered, which I was told was extremely brief; (3) Wi-Fi is off. Right?

If (2) the state of the modem being unregistered is not extremely brief after all, then we should change the title to explanatory text in that case -- not merely to let people access the menu, but so that people understand why they don't have any networking.

You're right that there should be an icon for Wi-Fi being on but not connected, but that seems like a separate problem from this one.

[Antti Kaijanmäki (kaijanmaki)]

mpt, please, no text on the panel. The icons are overflowing even with a small text and we can't predict how long they would be when translated.

What about this: I do what the spec says:
 - the Wi-Fi icon with 1 to 4 arcs (never 0 arcs) for the Wi-Fi signal strength
and use the wifi 0 arcs for "wifi on, not connected"
and use the nm-no-connection as "no network"

[Tony Espy (awe)]

@Antti

I think what you quote in comment #4 is the behavior as described by for a PC. For phones the behavior is slightly different:

 - the Wi-Fi icon with 1 to 4 arcs (never 0 arcs) for the Wi-Fi signal strength, if there is a Wi-Fi connection;
 - otherwise nothing

So @Matthew, you're suggesting we should show an icon when Wi-Fi is enabled but not connected, however in FlightMode no WiFi icon should appear, correct?

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Niklas Wenzel (nikwen)]

I often turn wifi on after enabling flight mode. Therefore, I believe the icon makes sense here.

[Michał Sawicz (saviq)]

I disagree, if you turn WiFi on, that's not flight mode any more, is it? Even so, the WiFi icon should only show again after you turn it on, not stay permanently.

[Niklas Wenzel (nikwen)]

That's true, of course. I agree that the icon can be dropped when wifi is turned off, but I think that it should still be shown when wifi is turned on.
I haven't seen this statement in this bug report yet, so I wanted to make sure this is considered when implementing it. ;)

[Niklas Wenzel (nikwen)]

Oh, and regarding the purpose of turning on wifi when in flight mode: I often do that to increase battery life. It can be quite helpful if you know that you won't need a network connection or that your phone won't be able to establish a network connection anyway.

[Matthew Paul Thomas (mpt)]

No, it isn't true that "that's not flight mode any more". It is fairly common for airlines to provide in-flight Wi-Fi while requiring that your device is in flight mode so that it is not making GSM, GPS, etc transmissions. <http://www.united.com/web/en-US/content/travel/inflight/wifi/default.aspx> That's why, I specced that "if you are on a flight that offers Wi-Fi, you may turn on Wi-Fi individually, while Flight Mode continues ensuring that other connections are off." <https://wiki.ubuntu.com/Networking#flight-mode> But all of that is irrelevant to this bug report.

This bug report is not about whether turning on Wi-Fi turns off Flight Mode, or vice versa, It is about whether the Wi-Fi *icon* should still appear in the indicator when Flight Mode is on. In my original spec, the Wi-Fi icon should appear only when Wi-Fi is connected, regardless of whether Flight Mode is on; there should be no "Wi-Fi off" or "Wi-Fi not connected" icon in the phone status bar, because space is at a premium. <https://wiki.ubuntu.com/Networking#Title> Paty's spec doesn't describe the indicator title at all, it just refers back to mine: "There could be several network indicators displayed simultaneously in the status bar including signal strength, data connection, Wi-Fi etc. Please refer to https://wiki.ubuntu.com/Networking#Network_menu_.28all_form_factors.29 for further details." <http://goo.gl/cDpygn>

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Víctor R. Ruiz (vrruiz)]

This is still happening

current build number: 122
device name: krillin
channel: ubuntu-touch/devel-proposed