Failing to connect to mysql doesn't show enough debugging information

[Ionuț Arțăriși]

When guestagent tries to connect to mysql and fails, all I can see in debug mode is:

Running cmd (subprocess): sudo /usr/bin/mysqladmin ping execute
 /usr/lib64/python2.6/site-packages/trove/openstack/common/processutils.py:137
2014-07-10 10:16:46.821 3452 DEBUG trove.openstack.common.processutils [-] Result was 1 execute /usr/lib64/python2.6/site-packages/trove/openstack/common/processutils.py:1622014-07-10 10:16:46.831 3452 ERROR trove.guestagent.datastore.mysql.service [-] Process execution
2014-07-10 10:16:46.832 3452 DEBUG trove.openstack.common.processutils [-] Running cmd (subprocess): /bin/ps -C mysqld h execute /usr/lib64/python2.6/site-packages/trove/openstack/common/processutils.py:137
2014-07-10 10:16:46.909 3452 INFO trove.guestagent.datastore.mysql.service [-] MySQL pid: 3252
2014-07-10 10:16:46.914 3452 INFO trove.guestagent.datastore.mysql.service [-] Service Status is BLOCKED.

It would be more useful to show what the actual error from the executed command was.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/106008

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106008
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=330d1fb7bb26a5b00d17b9dd19b86adeea0a2947
Submitter: Jenkins
Branch: master

commit 330d1fb7bb26a5b00d17b9dd19b86adeea0a2947
Author: Ionuț Arțăriși <email address hidden>
Date: Thu Jul 10 12:25:42 2014 +0200

    show stdout/err from failed command execution

    When executing a command the mysql service status command it is useful
    to see the actual output of the failing command in debug mode, not just
    the exit status.

    Add a log_output_on_error parameter to execute_with_timeout() so this
    can be reused.

    Change-Id: Iff931d0489754303e099e8567bca3237fd476f8f
    Closes-Bug: #1340124