AWS::EC2::VolumeAttachment must not support any updates

[Pavlo Shchelokovskyy]

According to AWS docs AWS::EC2::VolumeAttachment resource does not support any updates [1]. In Heat our AWS-compatible resource supports updates of all properties.

To align our AWS::EC2::VolumeAttachment with actual AWS behavior this update logic must be moved to the native OS::Cinder::VolumeAttachment resource.

However this addition of update logic is already a part of Icehouse release, so it must be deprecated first.

[1] http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volumeattachment.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/106623

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/113809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106623
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=234451b872523293e07c8767e810a634cccf0ee5
Submitter: Jenkins
Branch: master

commit 234451b872523293e07c8767e810a634cccf0ee5
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Jul 9 18:48:24 2014 +0300

    Move VolumeAttachment updates to Cinder resource

    According to AWS docs AWS::EC2::VolumeAttachment resource does not
    support any updates [1]. Support of updates in our AWS-compatible
    resource is a bug and needs to be fixed without deprecation period.

    This patch moves VolumeAttachment update logic to native Cinder
    resource.

    [1] http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volumeattachment.html

    Change-Id: I54d302dbec66ddd49c4a774376df99e7e9d63980
    Partial-Bug: #1340096

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/113809
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=40f168cf58bb8ca244d8a2567ea77372e62dfa2e
Submitter: Jenkins
Branch: master

commit 40f168cf58bb8ca244d8a2567ea77372e62dfa2e
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Aug 12 19:12:48 2014 +0300

    Deny updates to AWS::EC2::VolumeAttachment

    In accordance with AWS docs [1] AWS VolumeAttachment does not support
    updates of any of its properties.

    [1] http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volumeattachment.html

    Change-Id: I6d79536c68bed60d9b86c662147e35a9b2da6c1c
    Closes-Bug: #1340096