CloudInit does not use ssh client

Bug #1339976 reported by Jesse Meek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Jesse Meek

Bug Description

cloudinit/sshinit/configure.go:50

func RunConfigureScript(script string, params ConfigureParams) error {
 logger.Debugf("Running script on %s: %s", params.Host, script)
 client := params.Client
 if client == nil {
  client = ssh.DefaultClient
 }
 cmd := ssh.Command(params.Host, []string{"sudo", "/bin/bash"}, nil)
 cmd.Stdin = strings.NewReader(script)
 cmd.Stderr = params.ProgressWriter
 return cmd.Run()
}

client is never used. It compiles because of the if check. Change ssh.Command to client.Command.

Curtis Hovey (sinzui)
Changed in juju-core:
importance: Undecided → High
Jesse Meek (waigani)
Changed in juju-core:
status: Triaged → Fix Committed
Andrew Wilkins (axwalk)
Changed in juju-core:
milestone: none → 1.21-alpha1
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.