Stack inconsistency after app deletion

[Serg Melikyan]

To expose IP addresses of Instance in MuranoPL we place new entry to outputs section in Heat template that reference corresponding OS::Nova::Server resource. During clean-up stage, if some application was deleted from environment, we remove corresponding OS::Nova::Server resource, but reference in outputs section stays. Stack with reference to resource that is not present in template is invalid - environment deployment fails.

{"explanation": "The server has either erred or is incapable of performing the requested operation.", "code": 500, "error": {"message": "The Referenced Attribute (testMurano addresses) is incorrect.", "traceback": ... }

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/105686

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/105686
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=4da6c43dd2bd2ddd8edf4266d4794a4395aa5f34
Submitter: Jenkins
Branch: master

commit 4da6c43dd2bd2ddd8edf4266d4794a4395aa5f34
Author: Serg Melikyan <email address hidden>
Date: Wed Jul 9 15:56:06 2014 +0400

    Fix stack inconsistency after app deletion

    To expose IP addresses of Instance in MuranoPL we place new entry to
    outputs section in Heat template that reference corresponding
    OS::Nova::Server resource. During clean-up stage, if some application
    was deleted from environment, we remove corresponding OS::Nova::Server
    resource, but reference in outputs section stays.

    Stack with reference to resource that is not present in template is
    invalid - environment deployment fails.

    This change add code that removes references to OS::Nova::Server when
    corresponding Instance is deleted.

    Attention: this change fix issue that can break murano-ci gate

    Closes-bug: #1339630
    Co-Authored-By: Stan Lagun <email address hidden>
    Change-Id: I74d32034969dd7f554d74fac87f407388e52dd7e