Remove nova_proxy_admin_* from guestagent code

Bug #1339349 reported by Mat Lowery
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Nikhil Manchanda

Bug Description

Per SlickNik, "Things seem to work even with bogus values for those configs in the guest-agent."

https://bugs.launchpad.net/trove/+bug/1336618 will remove nova_proxy_admin_* from trove-guestagent.conf.sample. This bug is to remove it from the code.

Please remove nova_proxy_admin_* references here:
* http://git.io/TRGKBQ (here a regular Trove context is available to use instead)
* http://git.io/4G8Zfg (this is a periodic task so no context is available; since the conductor isn't using the context today, it is proposed that an empty dict be substituted here)

Revision history for this message
Dan Nguyen (daniel-a-nguyen) wrote :

The initial guest agent upgrades implementation also includes the use of nova_proxy_admin.

https://review.openstack.org/#/c/85225/71/trove/guestagent/heartbeat.py

I left as is for now but we can come back and fix it along with everything else.

Changed in trove:
status: New → Triaged
assignee: nobody → Nikhil Manchanda (slicknik)
importance: Undecided → Medium
milestone: none → juno-3
Changed in trove:
milestone: juno-3 → ongoing
milestone: ongoing → juno-3
milestone: juno-3 → ongoing
Changed in trove:
milestone: ongoing → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124355

Changed in trove:
status: Triaged → In Progress
Revision history for this message
Nikhil Manchanda (slicknik) wrote :

Issue is not release critical to hold juno-rc1 for. Moving to kilo-1.

Changed in trove:
milestone: juno-rc1 → kilo-1
Revision history for this message
Amrith Kumar (amrith) wrote :

Updating importance to "Wishlist" (bugscrub, 2014-10-23)

Changed in trove:
importance: Medium → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https://review.openstack.org/124355
Reason: This patch is being Abandoned as part of routine cleanup (older than a month). Please feel to restore if it is still active. Thanks!

Changed in trove:
milestone: kilo-1 → kilo-2
Changed in trove:
milestone: kilo-2 → kilo-3
Changed in trove:
milestone: kilo-3 → kilo-rc1
Changed in trove:
milestone: kilo-rc1 → liberty-1
Changed in trove:
assignee: Nikhil Manchanda (slicknik) → Amrith (amrith)
Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
assignee: Amrith (amrith) → Nikhil Manchanda (slicknik)
importance: Wishlist → Medium
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: liberty-1 → 4.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.