open-ils.pcrud inspects wrong IDL permacrud definition on jump

Bug #1339118 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

Affects all Evergreen versions circa 2.6.

Given this permacrud IDL chunk on the "ahn" class:

 <create permission="CREATE_HOLD_NOTIFICATION">
    <context link="hold" jump="usr" field="home_ou" />
</create>

A call to create a new "ahn" object will fail with the error:

Status: open-ils.pcrud: create on class au has no permacrud IDL entry

While it's true there's no <create/> definition for the "au" class, that is not supposed to be a requirement for creating "ahn" objects.

Revision history for this message
Mike Rylander (mrylander) wrote :

Whee! From the commit message:

We don't worry about checking permissions on foreign objects when we're
simply using them to get a context OU for the local object permission
testing. The "jump" field just gives us more layers of indirection, and
shouldn't cause a perm check, just like normal foreign context OUs.

Here it be:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/pcrud-jump-perm-ignore

tags: added: pcrud pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Works for me. Thanks, Mike! Sign-off pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1339118-pcrud-jump-perm-ignore

Since this was a quick turnaround, I'll leave time for input before merging.

Revision history for this message
Ben Shum (bshum) wrote :

Pushed to master.

Changed in evergreen:
milestone: none → 2.7.0-beta1
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
no longer affects: evergreen/2.5
no longer affects: evergreen/2.6
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.