Fuel for OpenStack

[system test] Wrong exception handling in test ceph ha restart ha

Bug #1338965 reported by Tatyanka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Artem Panchenko
Fuel for OpenStack 5.1
5.0.x
Fix Released
Medium
Fuel QA Team
Fuel for OpenStack 5.0.2

Bug Description

We add verification in tests ceph ha restart , to check is galera ok, and in case if not we try to raise Exception without catching it in exept block
        try:
            wait(lambda:
                 remote.execute(cmd)['exit_code'] == 0,
                 timeout=30 * 4)
            logger.debug("Mysql is UP")
        except:
            logger.error("MySQL Galera isn't ready on {host} node!".format(
                host=node_name))
            raise Exception

but should be except Exception: and then raise it. Also it would be nice if we appears in exept block add here message from sdterr
for this we shoud read it each time when execute command

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/105667

Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Artem Panchenko (apanchenko-8)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (stable/5.0)

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/106328

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/105667
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=41ba03754de70bf41ffef03ea751af8e4d837782
Submitter: Jenkins
Branch: master

commit 41ba03754de70bf41ffef03ea751af8e4d837782
Author: Artem Panchenko <email address hidden>
Date: Wed Jul 9 10:49:49 2014 +0300

    Fix exception handling in test ceph ha restart

    Added timeout exception handling and logging of
    stderr command output.

    Change-Id: Ia8f09f1deb951769c2463fab45b3781ecc4c9366
    Closes-bug: #1338965

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (stable/5.0)

Reviewed: https://review.openstack.org/106328
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=b74e1e2906a8d941a91a0386ed8f6875ad318ed2
Submitter: Jenkins
Branch: stable/5.0

commit b74e1e2906a8d941a91a0386ed8f6875ad318ed2
Author: Artem Panchenko <email address hidden>
Date: Wed Jul 9 10:49:49 2014 +0300

    Fix exception handling in test ceph ha restart

    Added timeout exception handling and logging of
    stderr command output.

    Change-Id: Ia8f09f1deb951769c2463fab45b3781ecc4c9366
    Closes-bug: #1338965

Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/5.1.x
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.