Puppet coding style

Bug #1338559 reported by Longgeek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Longgeek

Bug Description

# cd fuel-library/deployment/puppet/cluster
# rake lint
rake aborted!
No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)

(See full trace by running task with --trace)

# puppet-lint ./

WARNING: parameterised class parameter without a default value on line 6
WARNING: double quoted string containing no variables on line 59
WARNING: double quoted string containing no variables on line 67
WARNING: string containing only a variable on line 102
WARNING: variable not enclosed in {} on line 102
WARNING: quoted boolean value found on line 32
WARNING: line has more than 80 characters on line 73
WARNING: line has more than 80 characters on line 74
WARNING: indentation of => is not properly aligned on line 31
WARNING: indentation of => is not properly aligned on line 34
WARNING: indentation of => is not properly aligned on line 38
WARNING: indentation of => is not properly aligned on line 41
WARNING: indentation of => is not properly aligned on line 46
WARNING: indentation of => is not properly aligned on line 49
WARNING: ensure found on line but it's not the first attribute on line 86
WARNING: ensure found on line but it's not the first attribute on line 96
WARNING: ensure found on line but it's not the first attribute on line 105
WARNING: double quoted string containing no variables on line 6
WARNING: double quoted string containing no variables on line 39
WARNING: line has more than 80 characters on line 10
WARNING: indentation of => is not properly aligned on line 26
WARNING: indentation of => is not properly aligned on line 27
WARNING: indentation of => is not properly aligned on line 28
WARNING: indentation of => is not properly aligned on line 29
WARNING: ensure found on line but it's not the first attribute on line 26
WARNING: string containing only a variable on line 24
WARNING: line has more than 80 characters on line 36
WARNING: line has more than 80 characters on line 37
WARNING: line has more than 80 characters on line 38
WARNING: line has more than 80 characters on line 39
WARNING: line has more than 80 characters on line 40
WARNING: line has more than 80 characters on line 41
WARNING: line has more than 80 characters on line 42
WARNING: line has more than 80 characters on line 43
WARNING: indentation of => is not properly aligned on line 31
WARNING: indentation of => is not properly aligned on line 36
WARNING: indentation of => is not properly aligned on line 37
WARNING: indentation of => is not properly aligned on line 38
WARNING: indentation of => is not properly aligned on line 39
WARNING: indentation of => is not properly aligned on line 40
WARNING: indentation of => is not properly aligned on line 41
WARNING: indentation of => is not properly aligned on line 42
WARNING: indentation of => is not properly aligned on line 43
WARNING: indentation of => is not properly aligned on line 45
WARNING: indentation of => is not properly aligned on line 48
WARNING: indentation of => is not properly aligned on line 53
WARNING: indentation of => is not properly aligned on line 56
WARNING: string containing only a variable on line 26
WARNING: variable not enclosed in {} on line 26
ERROR: tab character found on line 11
ERROR: trailing whitespace found on line 1
ERROR: trailing whitespace found on line 5

Longgeek (longgeek)
Changed in fuel:
assignee: nobody → Longgeek (longgeek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/105153

Changed in fuel:
status: New → In Progress
Changed in fuel:
importance: Undecided → Low
milestone: none → 5.1
Changed in fuel:
milestone: 5.1 → 6.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/105153
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=6542cd2fa76f58f2563d82e8df78ee6ee1653a71
Submitter: Jenkins
Branch: master

commit 6542cd2fa76f58f2563d82e8df78ee6ee1653a71
Author: Longgeek <email address hidden>
Date: Mon Jul 7 20:41:38 2014 +0800

    The modified puppet codeing style

    Add the Rakefile file:
     * add dependency rubygems
     * disable 80 char line limit
     * disable class parameter defaults
    The remaining work is in the correction puppet code specifications

    Change-Id: I0e6f9bffd717ffe627f299852893573947b3f98a
    Closes-Bug: #1338559

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.