Puppet coding style
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Committed
|
Low
|
Longgeek |
Bug Description
# cd fuel-library/
# rake lint
rake aborted!
No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)
(See full trace by running task with --trace)
# puppet-lint ./
WARNING: parameterised class parameter without a default value on line 6
WARNING: double quoted string containing no variables on line 59
WARNING: double quoted string containing no variables on line 67
WARNING: string containing only a variable on line 102
WARNING: variable not enclosed in {} on line 102
WARNING: quoted boolean value found on line 32
WARNING: line has more than 80 characters on line 73
WARNING: line has more than 80 characters on line 74
WARNING: indentation of => is not properly aligned on line 31
WARNING: indentation of => is not properly aligned on line 34
WARNING: indentation of => is not properly aligned on line 38
WARNING: indentation of => is not properly aligned on line 41
WARNING: indentation of => is not properly aligned on line 46
WARNING: indentation of => is not properly aligned on line 49
WARNING: ensure found on line but it's not the first attribute on line 86
WARNING: ensure found on line but it's not the first attribute on line 96
WARNING: ensure found on line but it's not the first attribute on line 105
WARNING: double quoted string containing no variables on line 6
WARNING: double quoted string containing no variables on line 39
WARNING: line has more than 80 characters on line 10
WARNING: indentation of => is not properly aligned on line 26
WARNING: indentation of => is not properly aligned on line 27
WARNING: indentation of => is not properly aligned on line 28
WARNING: indentation of => is not properly aligned on line 29
WARNING: ensure found on line but it's not the first attribute on line 26
WARNING: string containing only a variable on line 24
WARNING: line has more than 80 characters on line 36
WARNING: line has more than 80 characters on line 37
WARNING: line has more than 80 characters on line 38
WARNING: line has more than 80 characters on line 39
WARNING: line has more than 80 characters on line 40
WARNING: line has more than 80 characters on line 41
WARNING: line has more than 80 characters on line 42
WARNING: line has more than 80 characters on line 43
WARNING: indentation of => is not properly aligned on line 31
WARNING: indentation of => is not properly aligned on line 36
WARNING: indentation of => is not properly aligned on line 37
WARNING: indentation of => is not properly aligned on line 38
WARNING: indentation of => is not properly aligned on line 39
WARNING: indentation of => is not properly aligned on line 40
WARNING: indentation of => is not properly aligned on line 41
WARNING: indentation of => is not properly aligned on line 42
WARNING: indentation of => is not properly aligned on line 43
WARNING: indentation of => is not properly aligned on line 45
WARNING: indentation of => is not properly aligned on line 48
WARNING: indentation of => is not properly aligned on line 53
WARNING: indentation of => is not properly aligned on line 56
WARNING: string containing only a variable on line 26
WARNING: variable not enclosed in {} on line 26
ERROR: tab character found on line 11
ERROR: trailing whitespace found on line 1
ERROR: trailing whitespace found on line 5
Changed in fuel: | |
assignee: | nobody → Longgeek (longgeek) |
Changed in fuel: | |
importance: | Undecided → Low |
milestone: | none → 5.1 |
Changed in fuel: | |
milestone: | 5.1 → 6.0 |
Fix proposed to branch: master /review. openstack. org/105153
Review: https:/