Failure in interface-attach may leave port around

[Drew Thorstensen]

When the interface-attach action is run, it may be passed in a network (but no port identifier). Therefore, the action allocates a port on that network. However, if the attach method fails for some reason, the port is not cleaned up.

This behavior would be appropriate if the invoker had passed in a port identifier. However if nova created the port for the action and that action failed, the port should be cleaned up as part of the failure.

The allocation of the port occurs in nova/compute/manager.py in the attach_interface method. Recommend that we de-allocate the port for the instance had no port_id been passed in.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/105238

[Matt Riedemann (mriedem)]

Do you have a stack trace for the failure so we can see where and how it failed?

[Chris Behrens (cbehrens)]

This appears to be a duplicate of 1341498... marking so.

[Chris Behrens (cbehrens)]

(I marked the other one as a duplicate of this one)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Drew Thorstensen (<email address hidden>) on branch: master
Review: https://review.openstack.org/105238
Reason: Abadoning in favor of the following change set: https://review.openstack.org/#/c/109178/

[Davanum Srinivas (DIMS) (dims-v)]

Fix proposed in https://review.openstack.org/#/c/109178/ is still in progress

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109178
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=78f7c744f675d618048968850259422338dd4955
Submitter: Jenkins
Branch: master

commit 78f7c744f675d618048968850259422338dd4955
Author: Eli Qiao <email address hidden>
Date: Tue Aug 19 11:16:56 2014 +0800

    Handle exception when attaching interface failed

    Currently, when attaching interface to an instance, nova doesn't
    handle the exception when calling `driver.attach_interface`, so
    the network info will leak when exception happened.

    This patch deallocates port when attaching interface failed,
    and give warn messages when deallocate port failed.

    Change-Id: I4fe67b5ce1b5ed41412d824a8c10b9a5e4fb325f
    Closes-bug: #1338551
    Co-authored-by: Alex Xu <email address hidden>