'Add' button at Admin->Identity->Groups->'Group management' doesn't work

[Timur Sufiev]

Upon pressing on that button modal spinner appears, then disappears and here we are again with empty 'Group Members' table.

Having investigated it a bit, I found that `data` string that is appended here https://github.com/openstack/horizon/blob/2014.2.b1/horizon/static/horizon/js/horizon.modals.js#L43 is not appended as it supposed: instead of adding <div class="modal hide">..</div> + <script>...</script> into <div id='modal_wrapper></div>, only <script>...</script> is appended. Also, after pressing 'Add' button several times there will be multiple identical <script> nodes inside modal_wrapper div. I do not understand the root cause of this bug, but moving <script>...</script> into <div class="modal hide">...</div> solved the problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/105109

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/105109
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=967187ed7ac4dffddedf23b9f83c1c485e59c362
Submitter: Jenkins
Branch: master

commit 967187ed7ac4dffddedf23b9f83c1c485e59c362
Author: Timur Sufiev <email address hidden>
Date: Mon Jul 7 14:19:05 2014 +0400

    Fix adding members to a group

    Somehow data string equal to '<div class="modal hide">...</div>
    <script>...</script>' is not appended correctly to '<div
    id="modal_wrapper">...</div>', but works fine if <script> node is
    placed into '<div class="modal hide">...</div>'.

    Change-Id: I0f4ecca740e86f9e328843ba39b2bc1b5ce35565
    Closes-Bug: #1338522