There's no record validation in v2

Bug #1338256 reported by Betsy Luzader
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Graham Hayes

Bug Description

Validation needs to be added to the recordsets in V1 for each record type, similarly to what was done for records in v1. See api/v1/records for an example.

Changed in designate:
assignee: nobody → Slawek Kaplonski (slawek-t)
Revision history for this message
Kiall Mac Innes (kiall) wrote :
Changed in designate:
status: New → Triaged
importance: Undecided → Critical
milestone: none → kilo-2
Kiall Mac Innes (kiall)
Changed in designate:
milestone: kilo-2 → kilo-3
Kiall Mac Innes (kiall)
Changed in designate:
status: Triaged → In Progress
assignee: Slawek Kaplonski (slawek-t) → Graham Hayes (grahamhayes)
Changed in designate:
milestone: kilo-3 → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169044

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/169044
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=707bc639ebe857b281702a1a711a0e961cffffe6
Submitter: Jenkins
Branch: master

commit 707bc639ebe857b281702a1a711a0e961cffffe6
Author: Graham Hayes <email address hidden>
Date: Mon Mar 30 19:31:29 2015 +0100

    Enable Record Data Validation in v2 API

    This enables the validation of data against schemas defined in the
    individual record objects

    * This is a permanent interface, implemented in a temp fashion *

    * Current we convert all the Record() objects to objects of the
      right type, and then validate. If validation is successful we restore
      the generic objects and send them to central.

    * We override the RecordSet validate() command, and add extra logic
      This allows for the v2 API to function, but recursive validation from
      a Domain object will not work, until another solution is found.

    * The way schemas are build up has also changed
    ** Each schema is built on .validate()
    ** There is no embedded "obj://<object_name>" references anymore
    ** The entire schema is added as one blob

    Closes-Bug: #1338256
    Implements: blueprint validation-cleanup
    APIImpact

    Change-Id: I8d1d614a9a9c0c1d3faeb0f98778231278f37bc4

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.