AssertionError says not a string in download_zipped

[Paul Everitt]

Error monitor just reported:

Exception when serving /communities/balkans-regional-conference-istanbul-june-30-july-4-2014/files/presentational-materials/audit-sessions/download_zipped

Traceback (most recent call last):
  File "/srv/osfkarl/production/45/eggs/waitress-0.8.9-py2.6.egg/waitress/channel.py", line 337, in service
    task.service()
  File "/srv/osfkarl/production/45/eggs/waitress-0.8.9-py2.6.egg/waitress/task.py", line 173, in service
    self.execute()
  File "/srv/osfkarl/production/45/eggs/waitress-0.8.9-py2.6.egg/waitress/task.py", line 392, in execute
    app_iter = self.channel.server.application(env, start_response)
  File "/srv/osfkarl/production/45/eggs/perfmetrics-2.0-py2.6.egg/perfmetrics/__init__.py", line 294, in app
    return nextapp(environ, start_response)
  File "/srv/osfkarl/production/45/eggs/karl-3.124-py2.6.egg/karl/timeit.py", line 73, in __call__
    return resp(environ, start_response)
  File "/srv/osfkarl/production/45/eggs/WebOb-1.1.1-py2.6.egg/webob/response.py", line 939, in __call__
    start_response(self.status, headerlist)
  File "/srv/osfkarl/production/45/eggs/waitress-0.8.9-py2.6.egg/waitress/task.py", line 376, in start_response
    'Header value %r is not a string in %r' % (v, (k, v))
AssertionError: Header value u'attachment; filename=balkans-regional-conference-istanbul-june-30-july-4-2014_files.zip' is not a string in ('Content-Disposition', u'attachment; filename=balkans-regional-conference-istanbul-june-30-july-4-2014_files.zip')

[Paul Everitt (paul-agendaless)]

I made ChrisR nosy, re-assigned to ChrisM, and raised the priority to Medium. The traceback has waitress in it and we got an error in another community, so it (a) isn't some isolated thing and (b) likely related to yesterday's switch to waitress.

ChrisM, does this issue ring any bells?

[Chris McDonough (chrism-plope)]

The paste http server lets these errors pass silently (it casts unicode header values to strings). Waitress doesn't, so this code needs to be fixed to not send unicode into header values.

[Chris McDonough (chrism-plope)]

I've committed a fix for this in 50008e3

[Paul Everitt (paul-agendaless)]

Thanks for the quick fix on this. I will try to do a release today (Saturday) to update production with this.

[Paul Everitt (paul-agendaless)]

Released in 3.125. Thanks Chris!