Glance

VMware store to use content-length when available

Bug #1336970 reported by Arnaud Legendre
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Arnaud Legendre
Glance 2014.2 "juno"

Bug Description

commit cb93eb60abf10af6fbb1ee438a6e8a51853e6788 changed the VMware store to use chunked encoding when the size is not known (or zero).
We still need to use Content-Length when we know the image size.

See original description
Tags: vmware
Arnaud Legendre (arnaudleg)
Changed in glance:
assignee: nobody → Arnaud Legendre (arnaudleg)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/104374

Changed in glance:
status: New → In Progress
Arnaud Legendre (arnaudleg)
tags: added: vmware
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/104374
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=8c161b6a4b0a7617ee224b23ada0a368e97eaae7
Submitter: Jenkins
Branch: master

commit 8c161b6a4b0a7617ee224b23ada0a368e97eaae7
Author: Arnaud Legendre <email address hidden>
Date: Wed Jul 2 15:33:54 2014 -0700

    VMware store: Use the Content-Length if available

    Change I579084460e7f61ab4042632d17ec0f045fa6f5af changed the VMware
    store to use chunked encoding to upload data to the underlying backend.
    We should do that only if the image size is not provided or zero and not
    all the time.

    This patch addressed the issue by checking the image_size before upload.

    Change-Id: If348be7fd24fd05146b0c86bef45b79f600cc0f7
    Closes-Bug: #1336970

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → juno-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance_store (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124193

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance_store (master)

Reviewed: https://review.openstack.org/124193
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=4917fe64b303383507bc26e5c7c43dfecd904c44
Submitter: Jenkins
Branch: master

commit 4917fe64b303383507bc26e5c7c43dfecd904c44
Author: Arnaud Legendre <email address hidden>
Date: Wed Sep 24 12:00:27 2014 -0700

    VMware store: Use the Content-Length if available

    Change I579084460e7f61ab4042632d17ec0f045fa6f5af changed the VMware
    store to use chunked encoding to upload data to the underlying backend.
    We should do that only if the image size is not provided or zero and not
    all the time.
    This patch addressed the issue by checking the image_size before upload.

    Merged in Glance: Change-Id: If348be7fd24fd05146b0c86bef45b79f600cc0f7
    Closes-Bug: #1336970

    Change-Id: I58efc8981b38d1e445f9acde669802b97e4b2077

Thierry Carrez (ttx)
Changed in glance:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.