xvfbwrapper should be with the conditional selenium imports

Bug #1336243 reported by Julie Pichon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Julie Pichon

Bug Description

Since xvfbwrapper is only a requirement when using selenium, it should be moved together with the conditional imports.

https://github.com/openstack/horizon/blob/44055c1676/horizon/test/helpers.py#L35

This was flagged by a packager.

Julie Pichon (jpichon)
Changed in horizon:
assignee: nobody → Julie Pichon (jpichon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/103875

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/103875
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=29da865d45dee5d09925afa77c988122c652778e
Submitter: Jenkins
Branch: master

commit 29da865d45dee5d09925afa77c988122c652778e
Author: Julie Pichon <email address hidden>
Date: Fri Jun 27 21:41:05 2014 +0100

    Make xvfbwrapper import dependent on the selenium imports

    It will not be required unless Selenium is also present.

    Change-Id: I9da1c596ad68b68c3ce4e8cd215646209dbaebe7
    Closes-Bug: #1336243

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.