use register_cli_opts instead of register_opt for multiple options

Bug #1336224 reported by Kanagaraj Manickam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Kanagaraj Manickam

Bug Description

In heat/bin/heat-keystone-setup-domain, register_opt is used to register many opts while olso provides an api already for the same. so this defect is filed to use the correct api.

Remove the following lines
for opt in opts:
    cfg.CONF.register_opt(opt, cli=True)

And

Add this line
cfg.CONF.register_cli_opt(opts)

Changed in heat:
assignee: nobody → Kanagaraj Manickam (kanagaraj-manickam)
summary: - use register_opts instead of register_opt for multiple options
+ use register_cli_opts instead of register_opt for multiple options
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/103847

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/103847
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=55a4802b806c111ff0b200c433dad9f36613db91
Submitter: Jenkins
Branch: master

commit 55a4802b806c111ff0b200c433dad9f36613db91
Author: Kanagaraj Manickam <email address hidden>
Date: Tue Jul 1 16:43:45 2014 +0530

    use register_cli_opts instead of register_opts

    oslo.config provides api register_cli_opts
    to register multiple opts at once and same
    is used in this patch to replace the
    register_opts

    Change-Id: I80b9bf37308c9e7085947200bc7c393c15e5e29d
    Closes-bug: #1336224

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.