pt-query-digest cannot parse binlogs from 5.6
Bug #1335960 reported by
Kenny Gryp
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Frank Cizmich |
Bug Description
The Binlog format in MySQL 5.6 has changed.
It looks something like this now:
#140528 13:25:58 server id 30 end_log_pos 902 CRC32 0x06479cb4 Xid = 27499090796
COMMIT/*!*/;
# at 902
The CRC32 is new.
Attached you can find a simple patch to fix the BinaryLogParser in pt-query-digest. It does not work with 5.5. I just quickly needed --type binlog to work.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-query-digest-cannot-parse-binlogs-from-5.6-1335960
- Frank Cizmich: Approve
-
Diff: 2190 lines (+2047/-38)9 files modifiedbin/pt-query-digest (+1/-1)
bin/pt-upgrade (+1/-1)
lib/BinaryLogParser.pm (+1/-1)
t/lib/BinaryLogParser.t (+92/-1)
t/lib/samples/binlogs/binlog-CRC32.txt (+43/-0)
t/lib/samples/binlogs/binlog011.txt (+1140/-0)
t/pt-query-digest/binlog_analyses.t (+9/-1)
t/pt-query-digest/samples/binlog001.txt (+33/-33)
t/pt-query-digest/samples/binlog011.txt (+727/-0)
Changed in percona-toolkit: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Frank Cizmich (frank-cizmich) |
milestone: | none → 2.2.9 |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Basically fixed as in Kenny's patch, except we made the CRC32 part optional in the regexp, so it's backwards compatible.