Failed to boot instance with admin role

[Feilong Wang]

Sometimes we need to create instances with admin role for some other tenants. But if we're booting the instance with a security group which name is duplicated in Neutron. Then user will run into an error and from the GUI, user don't know what happened.

The root cause of this issue is Neutron client doesn't honoured the tenant id, but get all the security group ids with the given name. So we need to fix this from both Nova and Neutron client side.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/103476

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/103703

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/103476
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=f9dbbb46e21ef524068efd308efb687c006c72c9
Submitter: Jenkins
Branch: master

commit f9dbbb46e21ef524068efd308efb687c006c72c9
Author: Fei Long Wang <email address hidden>
Date: Mon Jun 30 19:07:01 2014 +1200

    Improve the method find_resourceid_by_name_or_id

    Now the method find_resourceid_by_name_or_id doesn't honoured the
    project id. So if a user with admin role want to create an instance
    for another tenant, and using a a security group which name is
    duplicated in Neutron. Then the boot will fail.

    This patch is the fix on neutron client part. It will enhance the
    method find_resourceid_by_name_or_id to support project id as a
    parameter so as to get the correct security group id when passing
    a security gruop name.

    Change-Id: Ibd1829bd0f22f56c4fa210c67d10e1db5556c033
    Closes-Bug: 1335733

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/103703
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=904f88eab397308894d7dfb2b5e7abb89d65360d
Submitter: Jenkins
Branch: master

commit 904f88eab397308894d7dfb2b5e7abb89d65360d
Author: Fei Long Wang <email address hidden>
Date: Tue Jul 1 12:49:03 2014 +1200

    Fix nova boot failure using admin role for another tenant

    When user create instances with admin role for another tenant
    and specify a security group which name is duplicated in Neutron.
    Then user will run into an error and from the GUI, and user can't
    know what happened.

    The root cause is the method find_resourceid_by_name_or_id doesn't
    honoured the project info. So this fix will specify the project id
    for find_resourceid_by_name_or_id(), so this patch depends on the
    neutron client fix, see: https://review.openstack.org/#/c/103476/,
    which has been merged.

    Change-Id: I478ff4faa013a822483e39c8f5153a3a1e777f9b
    Closes-Bug: 1335733