This is a new ticket based on a discussion here:
https://bugs.launchpad.net/evergreen/+bug/800478
I have written a new version of transfer fund, and I would like to target it to 2.next. It modifies the acq.fund_allocation table by adding two new fields. These fields are fund_amount and conversion_ratio. There is already an amount field in acq.fund_allocation, and it remains there in this new commit.
The difference between amount and fund_amount is nil unless there is a difference in the exchange rates between a funding source and the fund itself. In those instances, amount represents the amount transferred by the funding source and fund_amount is the value transferred to the fund in the fund's currency.
This change allows exchange rates to be modified without the values in the funds fluctuating.
These changes also modify how acq.transfer_fund works. It allows users to transfer negative amounts, but instead of inserting negative values it reverses the order of the transfer. I.e. If fund1 transfer -50.00 to fund2, then in the database this is recorded as fund2 transferring 50.00 to fund1.
Liam
I have made my modifications to transfer fund and other ACQ year end stored procedures. As well, I have added a number of PgTap tests for these new features. The commit for master can be found here:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ ldw/LP1335688_ Change_ ACQ_Year_ End