Superknob effect parameters ignore default values

Bug #1335355 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Daniel Schürmann

Bug Description

If a parameter is linked to the superknob, in the loadEffect method it will initialize itself to whatever the superknob is set to (see effectparameterslot around 113, "onChainParameterChanged(m_dChainParameter);"). But the super knob defaults to 0, so this always puts that parameter to midi 0. Instead should this line just be removed so the parameter maintains its default? Or should the superknob default be 0.5?

Tags: effects midi
Owen Williams (ywwg)
Changed in mixxx:
milestone: none → 1.12.0
status: New → Confirmed
status: Confirmed → New
importance: Undecided → Low
Revision history for this message
Daniel Schürmann (daschuer) wrote :

I have already fixed this in https://github.com/mixxxdj/mixxx/pull/279
"Super softtakeover"

When an effect is loaded, the superknob is set to effects default.

This way, the effect sound as desired after loaded.
Some controllers have an endless Super button, so it is no issue there.
On controllers with a fixed scale Super button, it is required to enable soft-takover inside the midi mapping.

Changed in mixxx:
assignee: nobody → Daniel Schürmann (daschuer)
status: New → In Progress
Revision history for this message
Owen Williams (ywwg) wrote :

Cool I will look at your PR today.

jus (jus)
tags: added: effects midi
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7522

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.