Cells: set_admin_password doesn't work after an objects update

[Andrew Laski]

Set admin password fails in the child cell service with the following:

2014-06-24 20:45:08.403 29591 DEBUG nova.openstack.common.policy [req- None] Rule compute
:set_admin_password will be now enforced enforce /opt/rackstack/806.0/nova/lib/python2.6/site-packages/nova/openstack/common/
policy.py:288
2014-06-24 20:45:08.404 29591 ERROR nova.cells.messaging [req- None] Error processing mes
sage locally: 'dict' object has no attribute 'task_state'
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging Traceback (most recent call last):
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging File "/opt/rackstack/806.0/nova/lib/python2.6/site-packages/nova/c
ells/messaging.py", line 200, in _process_locally
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging resp_value = self.msg_runner._process_message_locally(self)
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging File "/opt/rackstack/806.0/nova/lib/python2.6/site-packages/nova/c
ells/messaging.py", line 1289, in _process_message_locally
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging return fn(message, **message.method_kwargs)
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging File "/opt/rackstack/806.0/nova/lib/python2.6/site-packages/nova/c
ells/messaging.py", line 692, in run_compute_api_method
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging return fn(message.ctxt, *args, **method_info['method_kwargs'])
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging File "/opt/rackstack/806.0/nova/lib/python2.6/site-packages/nova/c
ompute/api.py", line 201, in wrapped
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging return func(self, context, target, *args, **kwargs)
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging File "/opt/rackstack/806.0/nova/lib/python2.6/site-packages/nova/c
ompute/api.py", line 191, in inner
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging return function(self, context, instance, *args, **kwargs)
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging File "/opt/rackstack/806.0/nova/lib/python2.6/site-packages/nova/c
ompute/api.py", line 172, in inner
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging return f(self, context, instance, *args, **kw)
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging File "/opt/rackstack/806.0/nova/lib/python2.6/site-packages/nova/c
ompute/api.py", line 2712, in set_admin_password
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging instance.task_state = task_states.UPDATING_PASSWORD
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging AttributeError: 'dict' object has no attribute 'task_state'
2014-06-24 20:45:08.404 29591 TRACE nova.cells.messaging

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/103234

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/103234
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=825321cd7af9fc033d05f7bfbf730b50e4c6533c
Submitter: Jenkins
Branch: master

commit 825321cd7af9fc033d05f7bfbf730b50e4c6533c
Author: Andrew Laski <email address hidden>
Date: Fri Jun 27 16:23:27 2014 -0400

    Cells: Update set_admin_password for objects

    Cells code was calling the compute/api set_admin_password method with an
    old-world style instance and failing on the task_state attribute access.
    This adds set_admin_password to the list of methods handled via the
    cells RPC redirect method which is objects compatible.

    Change-Id: I12e212260ed62dc9380202de31fda928a9498dcb
    Closes-Bug: #1335315