Argument mismatch in inherited dashboard classes

Bug #1335180 reported by François Magimel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
François Magimel

Bug Description

One or many arguments are missing in some inherited classes in dashboards. Thus it could be an issue overriding them.

Changed in horizon:
status: New → In Progress
assignee: nobody → François Magimel (linkid)
Revision history for this message
Julie Pichon (jpichon) wrote :

Seems like something useful to have, since it's caused issues for people trying to extend Horizon before (e.g. bug 1334294).

Changed in horizon:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/107616

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/107616
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fe1c956211113f94bae6afc0396be51512cbca26
Submitter: Jenkins
Branch: master

commit fe1c956211113f94bae6afc0396be51512cbca26
Author: François Magimel <email address hidden>
Date: Thu Jul 17 09:43:38 2014 +0000

    Add mismatch arguments in inherited dashboard classes

    Add:
    * extra_context in the SetFlavorChoiceAction.get_help_text
        (panel project.instances) ;
    * form_class (kwargs) in the EditAttachmentsView.get_form
        (panel project.volumes).

    Those arguments were missing in children classes.

    Change-Id: I6d98feaae418e4d1aeed52ab2d6fce3427f481f6
    Closes-Bug: #1335180

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.