No provision to specify enable-rollback and timeout in stack-preview command

[Unmesh Gurjar]

IMHO, the purpose of stack-preview command is to validate all the stack parameters before actually creating the stack. Absence of any parameter during 'preview' would indirectly mean that the parameter value cannot be changed. Therefore, the stack-preview command should accept all the parameters accepted by stack-create.

Branch: master

Actual behavior:
stack-preview command does not accept the timeout and rollback options.

Expected Behavior:
timeout an rollback options should be accepted and consumed.

[Pavlo Shchelokovskyy (pshchelo)]

IMO the purpose of stack-preview is to show what resources are going to be created in the stack so that user does not have to skim through the (possibly very large and complex) template with bare eyes trying to extract all those defined resources - it is like a dry run for stack-create. The rollback and timeout instead concern how the stack with those resources is actually created, so it seems to me that stack-preview does not need supporting them.

[Unmesh Gurjar (unmesh-gurjar)]

As per the Orchestration API docs (http://developer.openstack.org/api-ref-orchestration-v1.html), the stack preview API accepts the 'disable_rollback' and 'timeout_mins' parameters. So, the heat CLI needs to accept and consume them.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/103552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/103552
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=0a8c9b96874445107633a9c534688bb32206f462
Submitter: Jenkins
Branch: master

commit 0a8c9b96874445107633a9c534688bb32206f462
Author: Unmesh Gurjar <email address hidden>
Date: Mon Jun 30 06:19:41 2014 -0700

    Added timeout and rollback params in stack-preview

    Added the support to specify timeout and enable_rollback
    parameters to the stack-preview command.

    Change-Id: Ifda2b6bdf2380ce22c6f2027ea8ee4e6e977cf60
    Closes-Bug: #1335098