Exception raised by attach interface is problematic

[Gary Kotton]

The exception raised is inappropriate. It just returns the instance object. This should be a coherent message.

[Davanum Srinivas (DIMS) (dims-v)]

Gary,

looks like the message itself has the information string. right?

class InterfaceAttachFailed(Invalid):
    msg_fmt = _("Failed to attach network adapter device to %(instance)s")

-- dims

[Gary Kotton (garyk)]

Dims,
When the exception is raised the entire instance object is printed out to the client. That is not user friendly.
I will change the exception to be the UUID - maybe that will make this easier to understand.
Gary

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/103091
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f8ae852c1a267a15f6b70026ad40d5d219fc0d33
Submitter: Jenkins
Branch: master

commit f8ae852c1a267a15f6b70026ad40d5d219fc0d33
Author: Gary Kotton <email address hidden>
Date: Fri Jun 27 04:11:51 2014 -0700

    Network: interface attach and detach raised confusing exception

    When the aforementioned operations failed they raised an exception
    that was not coherent - this is due to the fact that the instance object
    was passed to the exception. That would print the whole instance object
    which is really confusing to a openstack user. The exceptions should has passed
    the instance ID and not the instance.

    TrivialFix

    Change-Id: If3fa89b17210c1db3540cd813157b51e786e1494
    Closes-bug: #1335076