Horizon: Edit Project dialog doesn't fit window size

[Ido Ovadia]

Description of problem:
=======================
'Edit Project' dialog doesn't fit window size, so user need to scrole

Version-Release number of selected component:
=============================================
python-django-horizon-2014.1-7.el7ost.noarch
openstack-dashboard-2014.1-7.el7ost.noarch
openstack-dashboard-theme-2014.1-7.el7ost.noarch

How reproducible:
=================
100%

Steps to Reproduce:
===================
1. Login to Horizon
1. Click 'Admin' --> 'Identity Panel' --> 'Projects'
2. On created project click 'More' --> 'Edit Project'
3. On 'Edit Project' click 'Quota'

Actual results:
===============
1. Dialog doesn't fit window size
2. There is no scroll bar on the dialog.
3. scrolling done on both dialog and the background window

Expected results:
=================
1. The dialog should fit window size.
2. If it is large there should be a scroll bar on the right size.
3. Scrolling done on upper window only.

Additional info:
================
A screenshot is enclosed

[Santiago Baldassin (santiago-b-baldassin)]

This sounds like a duplicate of https://bugs.launchpad.net/horizon/+bug/1334876. The styles applied to _workflow.html need to be upated, once we do that, both issues will be fixed. I actually would rewrite the two bugs into a single one saying that the workflows modal are not scrollable :)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/103141

[Matthias Runge (mrunge)]

I think, making workflows scrollable is not the right solution to the issue, that the modal or workflow is just too long.
I'd prefer more a solution to better use the free space on the screen.

[Liz Blanchard (lblanchard)]

Hi All,

I've done some thinking around a redesign for this modal. I agree that making the list of Quota parameters scrollable would really just be a quick fix and we should be thinking about where we should take this modal in the future rather than implementing this quick fix. I'd like it to follow some of the future design patterns that we are seeing emerge in the Launch Instance Workflow design being done here:
https://blueprints.launchpad.net/horizon/+spec/launch-instance-ux-enhancement

Also, we should keep in mind the work that is happening around supporting difference sizing of modals here:
https://blueprints.launchpad.net/horizon/+spec/modals-and-supporting-different-screen-sizes

One last thing to think about here is that there is an effort around improving the inline help within forms which may remove the help text from the right hand side, giving much more real estate to the fields needing to be presented in the modal.

What do you all think about implementing a two column layout to fix this bug as a first step towards a larger redesign which turns this into a wizard type modal? Here is a screenshot of what I'm thinking:
http://people.redhat.com/~lsurette/OpenStack/Edit%20Project%20-%20Quota

Thoughts?

Liz

[OpenStack Infra (hudson-openstack)]

Change abandoned by Santiago Baldassin (<email address hidden>) on branch: master
Review: https://review.openstack.org/103141

[Julie Pichon (jpichon)]

Patch is abandoned, reverting status.

[Swati Sharma (swati-shukla1)]

Hi Nikunj,

Are you working on this?

[Nikunj Aggarwal (nikunj2512)]

Hi Swati,

yes, i am working on this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146314

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146314
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=efef69b95d286f1ee1e82a36bf2e4e32b3db8d7f
Submitter: Jenkins
Branch: master

commit efef69b95d286f1ee1e82a36bf2e4e32b3db8d7f
Author: nikunj2512 <email address hidden>
Date: Sun Jan 11 16:15:45 2015 +0530

    Changes Identity->Projects Forms into Horizontal Forms

    This patch converts the Create & Edit modal forms of Identity->Projects
    Panel into horizontal form. As the current modal form for 'quotas' to
    big. So, with the help of horizontal forms, this patch makes the form
    length smaller.

    Change-Id: I46e5b0c0fc16c3b5e7ece076c5f25d2c17971b9c
    Closes-bug: #1334897