OpenStack Compute (nova)

Nova api service doesn't handle SIGHUP signal properly

Bug #1334647 reported by Rajesh Tailor on 2014-06-26

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Cinder	Fix Released	Medium	Huang Zhiteng	Cinder 2015.1.0 "kilo"
Icehouse	Fix Released	Undecided	Unassigned
Juno	Fix Released	Undecided	Unassigned	Cinder 2014.2.1
OpenStack Compute (nova)	Fix Released	Undecided	Rajesh Tailor	OpenStack Compute (nova) 2014.2 "juno"
Icehouse	Fix Released	Undecided	Unassigned	OpenStack Compute (nova) 2014.1.4
oslo-incubator	Invalid	Medium	Unassigned

Bug Description

When SIGHUP signal is send to nova-api service, it doesn't complete processing of all pending requests before terminating all the processes.

Steps to reproduce:

1. Run nova-api service as a daemon.
2. Send SIGHUP signal to nova-api service.
kill -1 <parent_process_id_of_nova_api>

After getting SIGHUP signal all the processes of nova-api stops instantly, without completing existing request, which might cause failure.
Ideally after getting the SIGHUP signal nova-api process should stop getting new requests and wait for existing requests to complete before terminating all the processes and restarting all nova-api processes.

Tags:

Rajesh Tailor (rajesh-tailor) on 2014-06-26

Changed in nova:
assignee:	nobody → Rajesh Tailor (rajesh-tailor)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-03: Fix merged to nova (master)

Reviewed: https://review.openstack.org/104099
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=224a3de466d48301ab638b60ca47d19ad6b1b1dc
Submitter: Jenkins
Branch: master

commit 224a3de466d48301ab638b60ca47d19ad6b1b1dc
Author: abhishekkekane <email address hidden>
Date: Tue Jul 1 02:10:56 2014 -0700

Nova api service doesn't handle SIGHUP properly

    When SIGHUP signal is sent to nova-api service, it doesn't complete
    processing of all pending requests before terminating all the
    processes.

Closes-Bug: #1334647

Change-Id: I3f7bd0ba5ef1bb716a97635252abe251053a669d

Changed in nova:
status:	New → Fix Committed

Russell Bryant (russellb) on 2014-07-23

Changed in nova:
milestone:	none → juno-2
status:	Fix Committed → Fix Released

Doug Hellmann (doug-hellmann) on 2014-08-05

Changed in oslo:
importance:	Undecided → Medium
status:	New → Triaged

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2014-09-19:

It looks like the fix was not in incubated code.

Changed in oslo-incubator:
status:	Triaged → Invalid

Thierry Carrez (ttx) on 2014-10-16

Changed in nova:
milestone:	juno-2 → 2014.2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-21: Fix proposed to nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/129839

Huang Zhiteng (zhiteng-huang) on 2014-10-21

Changed in cinder:
assignee:	nobody → Huang Zhiteng (zhiteng-huang)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-21: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129851

Changed in cinder:
status:	New → In Progress

Jay Bryant (jsbryant) on 2014-10-21

Changed in cinder:
importance:	Undecided → Medium

Mike Perez (thingee) on 2014-10-21

Changed in cinder:
milestone:	none → kilo-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-22: Fix proposed to cinder (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/130110

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-22: Fix proposed to cinder (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/130111

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-22: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/129851
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6c3ad4cf55c5f4cb610fb2625aed1286857b6c67
Submitter: Jenkins
Branch: master

commit 6c3ad4cf55c5f4cb610fb2625aed1286857b6c67
Author: Zhiteng Huang <email address hidden>
Date: Tue Oct 21 17:05:50 2014 +0800

Cinder api service doesn't handle SIGHUP properly

    When SIGHUP signal is sent to cinder-api service, it doesn't complete
    processing of all pending requests before terminating all the
    processes.

This change is a copy of Abhishek Kekane's fix for nova api.

Change-Id: I049d2aa2f3ad1fe388e00213a71f374803ed409a
Closes-Bug: #1334647

Changed in cinder:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-22: Fix merged to nova (stable/icehouse)

Reviewed: https://review.openstack.org/129839
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f086ca3272be2fcb0276822209a4b7d2078670d7
Submitter: Jenkins
Branch: stable/icehouse

commit f086ca3272be2fcb0276822209a4b7d2078670d7
Author: abhishekkekane <email address hidden>
Date: Tue Jul 1 02:10:56 2014 -0700

Nova api service doesn't handle SIGHUP properly

    When SIGHUP signal is sent to nova-api service, it doesn't complete
    processing of all pending requests before terminating all the
    processes.

Closes-Bug: #1334647

Change-Id: I3f7bd0ba5ef1bb716a97635252abe251053a669d
(cherry picked from commit 224a3de466d48301ab638b60ca47d19ad6b1b1dc)

tags:

added: in-stable-icehouse

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-24: Fix merged to cinder (stable/juno)

Reviewed: https://review.openstack.org/130111
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f3320fc666c156349c2e8235a4b03d6ff9edd4de
Submitter: Jenkins
Branch: stable/juno

commit f3320fc666c156349c2e8235a4b03d6ff9edd4de
Author: Zhiteng Huang <email address hidden>
Date: Tue Oct 21 17:05:50 2014 +0800

Cinder api service doesn't handle SIGHUP properly

    When SIGHUP signal is sent to cinder-api service, it doesn't complete
    processing of all pending requests before terminating all the
    processes.

This change is a copy of Abhishek Kekane's fix for nova api.

    Change-Id: I049d2aa2f3ad1fe388e00213a71f374803ed409a
    Closes-Bug: #1334647
    (cherry picked from commit 6c3ad4cf55c5f4cb610fb2625aed1286857b6c67)

tags:

added: in-stable-juno

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-27: Fix merged to cinder (stable/icehouse)

#10

Reviewed: https://review.openstack.org/130110
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=24759d9cefdf23e82598b6b57b9bd122d767dd31
Submitter: Jenkins
Branch: stable/icehouse

commit 24759d9cefdf23e82598b6b57b9bd122d767dd31
Author: Zhiteng Huang <email address hidden>
Date: Tue Oct 21 17:05:50 2014 +0800

Cinder api service doesn't handle SIGHUP properly

    When SIGHUP signal is sent to cinder-api service, it doesn't complete
    processing of all pending requests before terminating all the
    processes.

This change is a copy of Abhishek Kekane's fix for nova api.

    Change-Id: I049d2aa2f3ad1fe388e00213a71f374803ed409a
    Closes-Bug: #1334647
    (cherry picked from commit 6c3ad4cf55c5f4cb610fb2625aed1286857b6c67)

Thierry Carrez (ttx) on 2014-12-18

Changed in cinder:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-04-30

Changed in cinder:
milestone:	kilo-1 → 2015.1.0

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.