linuxbridge agent delete a physcial interface

Bug #1334634 reported by mouadino
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Armando Migliaccio

Bug Description

How to reproduce ?
===============

1. Use Linux bridge agent.
2. Set the physical interface to something like:

  physical_interface_mappings= physnet1:eth0,physnet2:eth0.4000
3. Start using the physnet2 by creating a port for example ...

What happen ?
===========

As soon as no one is using the bridge anymore and that the bridge need to be deleted, eth0.4000 is also deleted.

What is Expected ?
===============

eth0.4000 to not be deleted, it's a physcial interface afterward, neutron didn't create it, neither he should delete it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102811

Changed in neutron:
assignee: nobody → mouadino (mouadino)
status: New → In Progress
tags: added: linuxbridge
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Salvatore Orlando (<email address hidden>) on branch: master
Review: https://review.openstack.org/102811
Reason: This patch has been inactive long enough that I think it's safe to abandon.
The author can resurrect it if needed.

Revision history for this message
Li Ma (nick-ma-z) wrote :

Hi mouadino, are you still working on this patch?

Li Ma (nick-ma-z)
Changed in neutron:
assignee: mouadino (mouadino) → Li Ma (nick-ma-z)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217073

Changed in neutron:
assignee: Li Ma (nick-ma-z) → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/217073
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1ec34b7d0d38324053996394be90d6fdecfed3ef
Submitter: Jenkins
Branch: master

commit 1ec34b7d0d38324053996394be90d6fdecfed3ef
Author: Nick <email address hidden>
Date: Wed Aug 26 18:16:14 2015 +0800

    Linuxbridge-agent: fix bridge deletion

    Make sure that linuxbridge agent doesn't delete
    physical interfaces if they are specified in the
    physical_interface_mappings.

    Change-Id: I95e3c46b03ba2ae0872f5def47f26d4e8ea13094
    Closes-Bug: #1334634

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/219156

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (3.8 KiB)

Reviewed: https://review.openstack.org/219156
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=22188bb0d96b05e9e2a8eb6ed73b18b6d36fc2ac
Submitter: Jenkins
Branch: feature/pecan

commit 1ec34b7d0d38324053996394be90d6fdecfed3ef
Author: Nick <email address hidden>
Date: Wed Aug 26 18:16:14 2015 +0800

    Linuxbridge-agent: fix bridge deletion

    Make sure that linuxbridge agent doesn't delete
    physical interfaces if they are specified in the
    physical_interface_mappings.

    Change-Id: I95e3c46b03ba2ae0872f5def47f26d4e8ea13094
    Closes-Bug: #1334634

commit 6324f7f23d5debecf7201a371050e20527550a8c
Author: Kevin Benton <email address hidden>
Date: Sun Aug 30 19:15:27 2015 -0700

    Fix usage of netaddr '.broadcast'

    netaddr 0.7.16 changed the behavior of IPNetworks with /31 and /32
    prefixes to make their 'broadcast' attribute return None. This patch
    replaces the use of the attribute with a -1 index lookup to get the
    last address instead.

    Closes-Bug: #1490380
    Change-Id: I97d71c4051882ddd9e496c78cfbce840ad7a2b67

commit 8a588dc95ef6486f3d28706052ca8873210d32f7
Author: Neil Jerram <email address hidden>
Date: Mon Aug 31 11:16:24 2015 +0100

    Add lieutenants contact for networking-calico

    Change-Id: Idc688a380e82ea6a385efc7b459b46e2daed0b4a

commit 81c2a7787fc6991db3fd3550f803e60994a7689a
Author: Neil Jerram <email address hidden>
Date: Mon Aug 31 11:10:53 2015 +0100

    Adding networking-calico to sub_projects document

    Change-Id: I537936dcc1723c76c12e816ff04645abaa7a8431

commit bac73541f420d1802cdf48f4d35b3a6ad1f5b7ee
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Aug 24 17:58:12 2015 +0200

    [neutron-db-manage] Introduce contract and expand commands

    Those are just wrappers that pass proper @head revision into upgrade
    alembic API.

    Change-Id: I4d7e1bd992c3ad75fca6d72defa9f96565ad6ba9
    Partially-Implements: blueprint online-schema-migrations

commit 298d225e2962d41ae08f2777facc938a84bf4ef9
Author: Neil Jerram <email address hidden>
Date: Mon Jul 27 14:26:59 2015 +0100

    DHCP agent: add 'bridged' property to interface driver

    This allows a custom interface driver to use the reference DHCP agent
    to provide DHCP service to unbridged TAP interfaces, by overriding the
    definition of the property as follows.

        @property
        def bridged(self):
            return False

    Partial-Bug: #1486649
    Change-Id: I2c6bbd9df6833a65088173b021790eb23e64616b

commit cf003af20906f3ef556a39d4f4f7067193dbfb68
Author: Moshe Levi <email address hidden>
Date: Tue Aug 18 23:10:05 2015 +0300

    SR-IOV: deprecate agent_required option

    When SR-IOV introduce in Juno Agent supported only link state change
    Some Intel cards don't support setting link state, so to
    resolve it the SR-IOV mech driver supports agent and agent less mode.
    From Liberty the SR-IOV agent brings more functionality like
    qos and port security so we want to make the agent mandatory.
    (of course I already talked with Intel Guys to get their approval)

    This patch deprec...

Read more...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.