Branch/Source Builder poisons tickets when it cannot talk to Launchpad
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu CI Engine |
Confirmed
|
High
|
Francis Ginther |
Bug Description
The Branch/Source Builder poisons tickets by marking them failed when it cannot talk to Launchpad:
[2014-06-26 08:15:56,194] bsbuilder:
[2014-06-26 08:17:01,733] bsbuilder:
Traceback (most recent call last):
File "/srv/ci-
amqp_cb, ret = self.handle_
File "./branch-
upload_
File "/srv/ci-
ppa, package[
File "/srv/ci-
raise Exception("%r returned an error." % (cmd,))
Exception: ['dput', u'ppa:ci-
dput does a small amount of local verification. I propose we do this as well before we call it to separate the cases of invalid data from the ticket itself and genuine failure on our part either handling the ticket or talking to Launchpad. William points out that any error once dput starts talking to the server is either a bug in dput or a connectivity problem.
Changed in uci-engine: | |
assignee: | nobody → Francis Ginther (fginther) |
11:17 AM <wgrant> I'm not sure if it's possible to distinguish the types of errors locally, but you can do the local verification up-front as you say.
11:17 AM <wgrant> It may even be barely worth using dput...
11:54 AM <vila> wgrant: ... you mean, just doing the ftp upload "manually" and redoing the dput checks ?
11:54 AM <vila> s/and/after/
11:57 AM <wgrant> vila: If you're doing lots of local checks anyway, and you know the list of files that you're going to upload, dput doesn't provide a lot of value over a normal FTP client.