Branch/Source Builder poisons tickets when it cannot talk to Launchpad

[Evan]

The Branch/Source Builder poisons tickets by marking them failed when it cannot talk to Launchpad:

[2014-06-26 08:15:56,194] bsbuilder:INFO:upload_list: [{'files': [u'libpng_1.2.49-4ubuntu2~vila1ubuntu24_source.changes', u'libpng_1.2.49-4ubuntu2~vila1ubuntu24.debian.tar.bz2', u'libpng_1.2.49-4ubuntu2~vila1ubuntu24.dsc'], 'resource': u'/api/v1/fullsubticket/2/', 'name': u'libpng', 'version': u'1.2.49-4ubuntu2~vila1ubuntu24', 'location': '/tmp/tmpcsEB8q', 'id': 2, 'architecture': 'any'}]
[2014-06-26 08:17:01,733] bsbuilder:ERROR:Unexpected exception occurred
Traceback (most recent call last):
  File "/srv/ci-airline-bsb-worker/ci-utils/ci_utils/amqp_worker.py", line 198, in _on_message
    amqp_cb, ret = self.handle_request(params, logger)
  File "./branch-source-builder/bsbuilder/run_worker.py", line 114, in handle_request
    upload_package.upload_source_packages(ppa, upload_list)
  File "/srv/ci-airline-bsb-worker/branch-source-builder/bsbuilder/upload_package.py", line 122, in upload_source_packages
    ppa, package['location'])
  File "/srv/ci-airline-bsb-worker/branch-source-builder/cupstream2distro/packagemanager.py", line 479, in upload_package
    raise Exception("%r returned an error." % (cmd,))
Exception: ['dput', u'ppa:ci-engineering-airline-staging/ci-pool-001', 'libpng_1.2.49-4ubuntu2~vila1ubuntu24_source.changes'] returned an error.

dput does a small amount of local verification. I propose we do this as well before we call it to separate the cases of invalid data from the ticket itself and genuine failure on our part either handling the ticket or talking to Launchpad. William points out that any error once dput starts talking to the server is either a bug in dput or a connectivity problem.

[Evan (ev)]

11:17 AM <wgrant> I'm not sure if it's possible to distinguish the types of errors locally, but you can do the local verification up-front as you say.
11:17 AM <wgrant> It may even be barely worth using dput...
11:54 AM <vila> wgrant: ... you mean, just doing the ftp upload "manually" and redoing the dput checks ?
11:54 AM <vila> s/and/after/
11:57 AM <wgrant> vila: If you're doing lots of local checks anyway, and you know the list of files that you're going to upload, dput doesn't provide a lot of value over a normal FTP client.